Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Jun 24, 2025 at 04:12:46PM +0100, Frediano Ziglio wrote:
> On Tue, Jun 24, 2025 at 3:35 PM Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote:
> > > OT: the flow of read_file (specifically "what" handling) looks
> > > weird... can I change it?
> >
> > It tries to avoid duplication of PrintErr calls, while including what
> > failed in the error message. Looks like somebody really wanted to avoid
> > using goto here... Sure, if you want to clean it up go ahead.
> >
> 
> 2 styles came into my mind
> gotos: 
> https://gitlab.com/xen-project/people/fziglio/xen/-/blob/flow1/xen/common/efi/boot.c?ref_type=heads#L765

This one, harder to make a mistake if for example there would be a call
with different error reporting.

> no errors: 
> https://gitlab.com/xen-project/people/fziglio/xen/-/blob/flow2/xen/common/efi/boot.c?ref_type=heads#L765
> 
> What do you think?
> 
> Frediano

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature