[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

To: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
From: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 24 Jun 2025 16:35:29 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
Delivery-date: Tue, 24 Jun 2025 14:35:41 +0000
Feedback-id: i1568416f:Fastmail
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote:
> OT: the flow of read_file (specifically "what" handling) looks
> weird... can I change it?

It tries to avoid duplication of PrintErr calls, while including what
failed in the error message. Looks like somebody really wanted to avoid
using goto here... Sure, if you want to clean it up go ahead.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
  - From: Jan Beulich
- Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
  - From: Frediano Ziglio

References:
- [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2
  - From: Frediano Ziglio
- [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
  - From: Frediano Ziglio
- Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
  - From: Marek Marczykowski-Górecki
- Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
  - From: Frediano Ziglio

Prev by Date: [PATCH v2 2/2] xen/efi: Support loading initrd using GRUB2 LoadFile2 protocol
Next by Date: Re: [PATCH v2 1/2] xen/efi: Handle cases where file didn't come from ESP
Previous by thread: Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
Next by thread: Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.