[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] console: Do not duplicate early printk messages on conring flush
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 17 Jun 2025 08:34:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/CqsIrdGBjKGPG7A2+c9dkfoIZsjNWgoPUATn9f4q8E=; b=cf9FPJC7/jqp1+ba8FtQMOBoce/iB1NNcyE1BXWFA4sKlVo/tcUjRfCyXQCO8Z3ynsTkF9npKBv8ThZt3Nqbcacf2hCrSMW94kFg9YwB+DCXmnjw5+HcKUrFTDRbCf8cVyTH3M8TjVROmi7x95kcd9bYaWCjsNSGtn4zXmOlf4dmtTpeu4NcdDrHdDYkTla/9xj6SNIILIzswiMRBxg4oUb4mSk50ZlNZZTbHdHQkfAZlV3babEzasJuvrC1HZQuvtCQyGh8KfBzBr8tlhclnyL4BT/o9f2LXpzQXapgrkZdEPWoifHaF7Yj0ZPiYzaMwKktFGZbrp4C/7fkvT4shw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/CqsIrdGBjKGPG7A2+c9dkfoIZsjNWgoPUATn9f4q8E=; b=hmCRc8IT8ajwypnulvJOB6eHIro+fPxJhJ/xZ2mnRA8BhHsKknTU0VFSdU3CULUvr6Gx/EsCt33O9twOBfEu6DGTqx0WC7ketkoXfKXaumf8xav2XWdgKe+/5flY0iBeWSTkmGN49PzPUWEizpJeVZoAZjdj/hrKDdqGSYZcpo/EKZGILJzmOPt+xDxUvQkPIsoAhMlGHgzYZ3W+seq28eR8gug/q8IOjbJwJWrSVpMZLFZEug+k1gVDw/1n9OlXaAjiZoX64GBBjgNev3YhlfzCK/XMqvI14OXDJkDNogxO4a3WaU5WcDTzNr6cbYuQZtuIM9QJI3BW44t0eJdJ7g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=I/q1GtTXD7Uy0GetUiKK93Wy2itF5q2mVJxNfpCjXxXRGag2SQQH+l4DO+5XfVFtBp/KxxxoI91lRo9s6Z1Z9cCEq4FcshlwGenL9NX1yd8hvzfWQ/q1EzAeSsqGEgfMRxrmD8UDDd9rGAS3qXrTJ89bZCdB/QJCp0cPWJStd6dzX+VZCXnqXhrnjwFBThO5xR4pHno57+pDz5oBEbOH08I3Ow9uoLZ/T7YhsKIm2yjSmyE4+/K/I4xbSRr3AD6opJt9Cjc+907x35BJIfqCIsf9D6u5og+02Q9IZAvZ7IoSyVvtBMU3d+87YAWs9kBGASOx22B27HzH1Q/LVlsCbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gSeTIF9ojrNkXYiNcQzP/lQnVSCDOd3MWvnzknjd55LkQa2sg6xu1ZsoM988uLKrEbEmu5pZq9O2Yo3aFi3f+671+8rhIGJCuWJ9DAm+mHHvqB1QchmnIwT3ykmL9xkIUF1OqD4r6V5B6EpsBK8WoPlP/SA8Dy3UhITrgG1f5RYerh+T7qaCQXQ5gRfswLqpAEYtT7FwzDVc6q86sJHTPLfsQab9mXCwtk8YEuMKDMXJxWtGWQ0y3xgmbsmC0dGK5TiBRLsWdvQDvNJKWHCJdHrMRvN8mhRtPAW6XsRUavMcVWK9Qun5Q9NNJVU5CqomC4LU9yQBDMvld/OZmeIdbA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 17 Jun 2025 08:35:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb31hHwh97vWYji0Krd5CV3ZKI8LQHBluA
- Thread-topic: [PATCH] console: Do not duplicate early printk messages on conring flush
Hi Michal,
> On 17 Jun 2025, at 08:19, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Commit f6d1bfa16052 introduced flushing conring in console_init_preirq().
> However, when CONFIG_EARLY_PRINTK is enabled, the early boot messages
> had already been sent to serial before main console initialization. This
> results in all the early boot messages being duplicated.
>
> Change conring_flush() to accept argument listing devices to which to
> flush conring. We don't want to send to serial at console initialization
> when using early printk, but we want these messages to be send at conring
NIT: s/send/sent/
> dump triggered by keyhandler.
>
> Fixes: f6d1bfa16052 ("xen/console: introduce conring_flush()")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> xen/drivers/char/console.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
This LGTM, I’ve also tested with fvp-base for arm64 with CONFIG_EARLY_PRINTK.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
