[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Fri, 6 Jun 2025 12:08:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lx3IxXBN5k5RcDcTzIpFvym+VVOBpMuufrYqlv1pobs=; b=p+7V5wy376wWdzq3tMn0By1Mb8Af+EAhtyhIYI7vYR2G6MZpp6ptCnw1vsT3hYuGgyxEXVxNcI/hWY2syET5eORuGkQDvuwi8/D3k1BZAxBFv+xAWO9U5E9VmUfVBOZZ512eCxSWxwsbZ4zcysml5G4CylnQ89kzVBkkvjoIA20cKpitb0HjFKhv1CxUpr82Ew/ovcFYh5ZEqx9v9XVIgzWjs+d8Np7zYkqgjld5QzUrSbjygSA3tsm/JMamrpdLwDM9U3Pg5ed0ZpA5ylPdn5QyYFFNF0mfo1d/13lZlQvOp/l2qR4k/XKHUehRrJrBWelCbOryhjmF6PGULMkEBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oC47nUlXDQAKHr8TOlVZHVU4py0hjJCLYAUpQM4viMsrJoWG4nf674fy6xTi5Ep4fMVLPzdBuoB7Dpgi1FcEiPfRPP+75W/w5p6yiBUdaNRQCp+WkdExhB8NxOtkbDCxqkUzAtyr0ctl4c3Dvd9DaVxnbrXCaH0BaPu/jitb/0XbwiWv0zSrJ7vVpxdOodwHtGNtaPjBdwTihl++FMoCyFh8FpSAGqZb0/LZjFXpL5zQIyXqldujFQ4OxvmVoUNvYvazNsbNuogw5W+3ajN0Tl1E2I6tr4M/C0GlpQyrjfxGtyi3L3kKzGL90X+Ff644Bq9uRsYprUcyDXC7ULfnCA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Jun 2025 10:09:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri Jun 6, 2025 at 10:59 AM CEST, Michal Orzel wrote:
>
>
> On 05/06/2025 21:48, Alejandro Vallejo wrote:
>> Part of an unpicking process to extract bootfdt contents independent of
>> bootinfo
>> to a separate file for x86 to take.
>>
>> Move functions required for early FDT parsing from device_tree.h and arm's
>> setup.h onto bootfdt.h
>>
>> Declaration motion only. Not a functional change.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>> ---
>> v2:
>> * Remove the u32 identifiers in the device_tree_get_u32() implementation
> I don't understand the reasoning behind changing u32->uint32_t only for one
> function in this patch while leaving others unmodified. Also what about u64?
> Either don't change any or change all.
Sure. Let's call the original u32->uint32_t change a misplaced mutation and
move on. The point is the motion, not these cleanups on top.
>
>> * Fix an existing const-stripping case.
> These points should be mentioned in the commit msg.
Sure.
>
> ~Michal
Cheers,
Alejandro
|
