[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h
- To: Alejandro Vallejo <agarciav@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Fri, 6 Jun 2025 10:59:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lt7+JgPak//uhAmKdPFbycTD6ldH9c/uva0/xO3FQBY=; b=U7zX5gvIjWKhjRQPsF0qL9AZOMP4/465uMD77Grr4tSs7mSRLVLqS0QI/+KqDQIsnCOssO7HgoOvw+O6N8tduTPQxqn2zcoBcLTQA/hi8zwOOtwt+SBYFqmkGFGSf+jZdhln//RYdCXF5zIGfPl4hSOkbX+vLcP7Qo1cmewBPjxOvlF5l6mpIczV21wjIVz9b951WypG6X6JonaUcHMeGo7AAeqp6noPBwnwqTaLLppM6NBh1dA+JGiWnPK5chgpC7hntDzip6iXCXIYZp8b1la9cWXgtTQmCxuHDzvXWhuro//VRSJ5x/12CtwBOKWkNKGMoI1dTIyjjUsOmkbVKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TdrSDoUy6ZG8QGr9ZS0JbuZV0lofNP5UOu02L8VRFJQw+WVfxuhy279tQvX2XHfvaKyDxKFYmQblcsSfc3sp78HHKaRfI7aYpGj3aUX3vCWpjDIZMR3GScYvPdJD4uQrIFG+4HtfS868bDf9luMGEQHS4a1BGKMqWsUSRRF5VI7iNbg8UdfAiQWDZ5G6PTU8FUK/I+JhCEDApP/3mNSf5XlpuHNU3/kSdjZKVIUyB7iLX/E28fCnYvTCPmeQJSATMHp2rOoRhQR0E+iXTmgxrouwEJ5tVRutJihMhNQBHM3WyGyUCRc2HY987fye+H0QAPqgfYNM2vVofGWPH7ovnw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Jun 2025 09:00:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2025 21:48, Alejandro Vallejo wrote:
> Part of an unpicking process to extract bootfdt contents independent of
> bootinfo
> to a separate file for x86 to take.
>
> Move functions required for early FDT parsing from device_tree.h and arm's
> setup.h onto bootfdt.h
>
> Declaration motion only. Not a functional change.
>
> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
> ---
> v2:
> * Remove the u32 identifiers in the device_tree_get_u32() implementation
I don't understand the reasoning behind changing u32->uint32_t only for one
function in this patch while leaving others unmodified. Also what about u64?
Either don't change any or change all.
> * Fix an existing const-stripping case.
These points should be mentioned in the commit msg.
~Michal
|
