[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 1/3] arm/mpu: Introduce MPU memory region map structure


  • To: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 5 Jun 2025 13:33:45 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pmKQvjwyH95o+2UdOedf5lPpQ0hP/Us2XZHP0WIppeA=; b=lSJbiyAfAkqY9OF09sbVRXeNDpdywgzKT8VUt9296xExw1ysJsNxQA1hz2jpfjImVfuV5zRn96c+zMvgmtYXmteJAgd8mAWyy4nLrTanYdDYB24PAZ0C16mdDoK82Et73NAkIJqQ8dpX0/9nA3pji40UXSDCSzpJsSwSfYKQAHqjACMn0qPIIZOLby6wr7Pcfcxzc3SrKJHfjKinvvoDeqPHPqI8PcMNj9PnR5/XDDCF7fbxYZ2W7T20HJbpcPIkRoxkVHvnKmpfR9xdjqwQ2GLviHX0cs6bulxrJD5v+FSgnUsPZgTbVVdXJVGKHJmxffv2UGWEIwSW1scmKyqb+Q==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pmKQvjwyH95o+2UdOedf5lPpQ0hP/Us2XZHP0WIppeA=; b=vgyyFGnvzarOJUwyoIVPyDOWXZMRbPYd1JQxWFwbNTsuK6kP5WzXEztNWcVqZxEjQBus/GBtdZBm0oT0tRt1Up6Z9joYsFB088WKNhO0cqKgndDOdjRkKRiJtd8/1X2aIrZnfEE38uDVKStr3By2wzk7eNq4KrNV2aV9BzgYTYLaNUxJWwKfwfWfTKSRZHFFZ/EM7drwg2Wxn0RYai+Oi/JDChAst1KU9rNSI603ifiyFAWhkQHeUTmfDkJKsMpC4QZjzdeMvLsFmvUksQc7yZ/QpKK026GVkbO2+d8qRefakw8j6KX3ddemuAX9HZ6jxTwzKBmbLTX4dPavLl96+g==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=PPb7bnSttIdbohfTvbfdFpEOvrBIKorZ+JutjycGyHauBdQTTuL3dulnit5k2+i5tv03QYDmwXdD1x1B8T6X0yPTSBiUxWf/cRGvWBWejzO7dhqjDTfjnq+6uW3rXvQ1yV4rQCA8KLqWcdF3WN4PhPRTglTMj81UUweHmm2yg8urNkjpn4X0old7VYYLJfe0QgN//yPhe3etsEO9PTEDbbf9+RyKlwJ/hngwH6AamaW36o1+JvfIGGT+0RDWlZxxTIwiIbODLnfaKTUwpKM14LC19GlMN3VVJASN3MqvUx3QiaEpTBeeQdqhfy2JhBCzy5+SxJZlUWz1ohAaBuPa3A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O4HFecs9ktR/tsMNJcdK8GH7BdZDLCBVVw1E+X/5SDl6o5NbBY+wa8lKRyBPSHv0W9w+OcDuWrop+hgm44f5gpRClni2pD1OEBsDbcCz0+D4+7zjg8mFoux2y/xG3LvQSWxXDJOl2UYnSLh8esEsL2THgpl4fy98TYB2MEGGmgyC7HKdLAIaOZ8XqCjoCsw3dpte/T9fg8pLG4bFD3vlEY0sTLoISvqJRZ3el+0HQcMne6rbL9QQERwCbNRRVPn0eJ5sSZJ1H6k9R47cJzZw/pJm0x7kvO/lKL2AKRWgvOTMszNW5U9PelvY+kEvfX29shf15WFhEp5jLC/9Tz588A==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 05 Jun 2025 13:34:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHb1XhE+9uzMCRJ9UO6OgGmjkgLx7PzYDyAgAExFACAAACHgA==
  • Thread-topic: [PATCH v1 1/3] arm/mpu: Introduce MPU memory region map structure

Hi Ayan,

>>> +/* Hypervisor Protection Region Base Address Register */
>>> +typedef union {
>>> +    struct {
>>> +        unsigned int xn:1;       /* Execute-Never */
>>> +        unsigned int ap_0:1;     /* Acess Permission */
>>> +        unsigned long ro:1;      /* Access Permission AP[1] */
>>> +        unsigned int sh:2;       /* Sharebility */
>> Typo: Sharebility -> Shareability.
> Ack
>> 
>> Also, from the patch the comments feels not aligned, is that the case?
> When you apply the patch, the comments look aligned (in the codebase). Does 
> it look the same for you ?

I didn’t apply the patch, ok then it’s just in my client I see it not aligned, 
sorry for the noise!

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.