[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 1/3] arm/mpu: Introduce MPU memory region map structure


  • To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Wed, 4 Jun 2025 19:19:57 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jtDwB5a4jaBk8/cJ+Rk3+5Pv6Jo34HQdVBLkmcHrKuQ=; b=dcJAF8mJxTHR6vOHxc4WiJ2NWJ9+A/Kqc8j1ikswRvPi6Lu3rWq0c4vNP1gy7uFpZPI3PJcaEpQ6f8apCw16+iW2pVcKmiL4AhVDS/s9udQJx2K9vAlf0yxpnZLvayb9Cn5A6PZIsbkKinXe+4CuLCcWkbQoVoQ2RP+sJPoYdkuV6W+RtawRWJc5LVsbfjfOB3BhS6ATz7C15ALQn+wHTIDUUrvqPXIYxH+/ydsWpaR+c65lVFbyOZ4XByMGGehatWB+FJ1myZ10/yVHJF+K9L2R0xfrkzj9GQwLfCpzV3pHrS2i68JW6fsM3LTbcC7Z7ChBMkU1/x3tfWTf/YFd/g==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jtDwB5a4jaBk8/cJ+Rk3+5Pv6Jo34HQdVBLkmcHrKuQ=; b=NZcNUPedAlCkpfAqk4Q91Cc7U6rabhU8NCJOKeTqsoE7AH4kN+j5Uc6+dZWyt9XiIqAWLfeSEk7wiEgIT8GyV4aZhFGc7ZXEvEVygz145d/IjnZKkRkHoBxC7bfMO54dlh43BBjSvC2wJ4MRcnz9wQdg2YTdxciwEZaz63z1eqqK3iEOro9pGdZMHHPUOqCuIMNpgkpRtdQH5bT8SFXsvKy9CEnkZy8FO1yKnpZeGpnddzpwadIwOcXeqR+aa2nqgU7ZNMmE+xhTKpMi5sZQGb7q85Ug1D1TeBV3AIlul/nAUZ639FJIE6CiJfup5KZA68ke3RX6shYp9EtjjusLXg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=WG1B6sKKOr4nEaaTjTkD3pvXcNh6GNDHE9Ojsf6PMM5uImZmO+kguAxbV2i0+OFvRCWqHEMCKa3WmXVYQfkFFuAtzykVqlTVV+xdRHyvjryPZKN5UxULXC7192C8s+H2wvQZL2LXZphQCK9XaYw5RFrVO+WYE3865WPOMgml2FqHm2TJXSPZ5Tjje08qG64Ngi22XRzEbFDnhikOnYVLYFe8fSui/fZBISV9DCV5/T4fF//zZ4YAvUeW0FkAzEWOsrVPqgOr8n/pqi/qszuquy1hI9dmBnJS7nIha2JbI+M0zmJeHT5bwC14ZRbWH4CYH/WJEc5PP+IAc6enXWp9pg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t9hXFK9dAqq2sA4EPlB5XxtX0OQRQGJnhiI1CtX+QVb5sZANOqWhDd/5HwyNCYry/9EQ6ylZgzLGeAoBScmhje30zy1GOTEGW/dfpqKBNZGRKoCH4/V5WDePn+PXUxSK7wYO4MfPV1xxjcYYu45Eyht8nYZ0fK04NIl5W5rA+P97Qxrv0d2suDAy2dlLR4hJ2tnX38ArnHHNTj/O4hmcRyvH+qG9W/Q4jdj2KTglPPaCz/in0loZFBGsZXshWbZmoZ12+Y6wOtdzaKjVTI3MffhCH48UtvQ33/Fn6u9nVyzeSzh/3HIaY/s8VhFXQZBDa+K4wY+yGtTb/dBEgOjPcw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 04 Jun 2025 19:20:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHb1XhE+9uzMCRJ9UO6OgGmjkgLx7PzYDyA
  • Thread-topic: [PATCH v1 1/3] arm/mpu: Introduce MPU memory region map structure

Hi Ayan,

> On 4 Jun 2025, at 18:43, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
> 
> Introduce pr_t typedef which is a structure having the prbar and prlar 
> members,
> each being structured as the registers of the AArch32 Armv8-R architecture.
> 
> Also, define MPU_REGION_RES0 to 0 as there are no reserved 0 bits beyond the
> BASE or LIMIT bitfields in prbar or prlar respectively.
> 
> Move pr_t definition to common code.
> Also, enclose xn_0 within ARM64 as it is not present for ARM32.
> 
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> ---
> xen/arch/arm/include/asm/arm32/mpu.h | 30 +++++++++++++++++++++++-----
> xen/arch/arm/include/asm/arm64/mpu.h |  6 ------
> xen/arch/arm/include/asm/mpu.h       |  6 ++++++
> xen/arch/arm/mpu/mm.c                |  2 ++
> 4 files changed, 33 insertions(+), 11 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/mpu.h 
> b/xen/arch/arm/include/asm/arm32/mpu.h
> index f0d4d4055c..ae3b661fde 100644
> --- a/xen/arch/arm/include/asm/arm32/mpu.h
> +++ b/xen/arch/arm/include/asm/arm32/mpu.h
> @@ -5,11 +5,31 @@
> 
> #ifndef __ASSEMBLY__
> 
> -/* MPU Protection Region */
> -typedef struct {
> -    uint32_t prbar;
> -    uint32_t prlar;
> -} pr_t;
> +#define MPU_REGION_RES0       0x0
> +
> +/* Hypervisor Protection Region Base Address Register */
> +typedef union {
> +    struct {
> +        unsigned int xn:1;       /* Execute-Never */
> +        unsigned int ap_0:1;     /* Acess Permission */
> +        unsigned long ro:1;      /* Access Permission AP[1] */
> +        unsigned int sh:2;       /* Sharebility */

Typo: Sharebility -> Shareability.

Also, from the patch the comments feels not aligned, is that the case?

> +        unsigned int res0:1;     /* Reserved as 0 */
> +        unsigned int base:26;    /* Base Address */
> +    } reg;
> +    uint32_t bits;
> +} prbar_t;
> +
> +/* Hypervisor Protection Region Limit Address Register */
> +typedef union {
> +    struct {
> +        unsigned int en:1;     /* Region enable */
> +        unsigned int ai:3;     /* Memory Attribute Index */
> +        unsigned int res0:2;   /* Reserved 0 by hardware */
> +        unsigned int limit:26; /* Limit Address */
> +    } reg;
> +    uint32_t bits;
> +} prlar_t;
> 
> #endif /* __ASSEMBLY__ */
> 
> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h 
> b/xen/arch/arm/include/asm/arm64/mpu.h
> index f0ce344e78..df46774dcb 100644
> --- a/xen/arch/arm/include/asm/arm64/mpu.h
> +++ b/xen/arch/arm/include/asm/arm64/mpu.h
> @@ -34,12 +34,6 @@ typedef union {
>     uint64_t bits;
> } prlar_t;
> 
> -/* MPU Protection Region */
> -typedef struct {
> -    prbar_t prbar;
> -    prlar_t prlar;
> -} pr_t;

I’m not sure I would do this, at some point there will be the transient flags 
and p2m type
and we know arm32 will need to store them in pr_t as additional members, 
instead 
arm64 will store them as part of prbar/prlar using the not used space (without 
writing them
in the HW registers)

> -
> #endif /* __ASSEMBLY__ */
> 
> #endif /* ARM_ARM64_MPU_H */
> diff --git a/xen/arch/arm/include/asm/mpu.h b/xen/arch/arm/include/asm/mpu.h
> index 8f06ddac0f..c8573a5980 100644
> --- a/xen/arch/arm/include/asm/mpu.h
> +++ b/xen/arch/arm/include/asm/mpu.h
> @@ -25,6 +25,12 @@
> 
> #ifndef __ASSEMBLY__
> 
> +/* MPU Protection Region */
> +typedef struct {
> +    prbar_t prbar;
> +    prlar_t prlar;
> +} pr_t;
> +
> #ifdef CONFIG_ARM_64
> /*
>  * Set base address of MPU protection region.
> diff --git a/xen/arch/arm/mpu/mm.c b/xen/arch/arm/mpu/mm.c
> index 86fbe105af..2fb6b822c6 100644
> --- a/xen/arch/arm/mpu/mm.c
> +++ b/xen/arch/arm/mpu/mm.c
> @@ -167,7 +167,9 @@ pr_t pr_of_addr(paddr_t base, paddr_t limit, unsigned int 
> flags)
>     /* Build up value for PRBAR_EL2. */
>     prbar = (prbar_t) {
>         .reg = {
> +#ifdef CONFIG_ARM64
>             .xn_0 = 0,
> +#endif
>             .xn = PAGE_XN_MASK(flags),
>             .ap_0 = 0,
>             .ro = PAGE_RO_MASK(flags)
> -- 
> 2.25.1
> 

Cheers,
Luca



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.