[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] device-tree: Move Arm's static-memory feature to common
- To: Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 3 Jun 2025 16:58:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZumHIjBi/UCD0syGquwVwzUx23wes+j9/Sllq/MIZX4=; b=W1qi8VE6M5GwhNwXJyfMxwMaCINEBCF1JapwQcJuKgyYR8EAWZ+9OON1JgxMssGtFReRUC4YLLn5PhMHCbmBhmCmfLbG8oCXtQE5QNXY6drw0uGUcYH7JwOl0r4a5qhhPlVF5WzudnslKAkBm3ztSy+DRnj9RL0GJQ61fAnsyPCsJnVWK0ytzWStRYmOdvUIApEqT+UjleSL5QB2DXlQWBJqUaHc2A8WqSB5pkiN1vIC8bObA2Wi1Z3qbdjkSDJDmhzyHeia1wCEdVRWXfCTbQQMdHTD8ZjOeskUdKBDGTBBPk2DjxfobWisvhZsv6ZwBPRkKEJR00SdwACbOi4qhA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MZ6AtuHzaMqLbEKSCIjOh7uOXVeSUJhYb7ymOUxDg+LjnHmZhjHG+n0ar4vztMX8Wft9c537Dj8TPKP8XPOffe+bqkIuq/D9LXyLsdqoVX3FJG59EG9Yk7z4ifCBjGpxdaIkNQjWoJV5FVneNVZzu7gwfMaFmiPcQcMZ+MFhvZy2kiV487/ICPt15tnzxUTfJLajE8B4d8iBHPqifkwT9R1B1si4ALeikgKLHSo+AK0PYA/inI6QVfO1TlvNh20egpiAb2IqLZCH5rOPcnmPZ2BmLhS/fE2kgw/+w6JtHU6rBBuRqAroYbR71iry2uidAlfHZ4+25+q7LO2rdiKeOw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 03 Jun 2025 14:59:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/06/2025 15:28, Julien Grall wrote:
> Hi Michal,
>
> On 03/06/2025 11:03, Michal Orzel wrote:
>> This feature is arch agnostic, thus move it to common.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> With one remark below:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> [...]
>
>> diff --git a/xen/arch/arm/include/asm/static-memory.h
>> b/xen/include/xen/static-memory.h
>> similarity index 93%
>> rename from xen/arch/arm/include/asm/static-memory.h
>> rename to xen/include/xen/static-memory.h
>> index a32a3c6553bc..e445aa80578c 100644
>> --- a/xen/arch/arm/include/asm/static-memory.h
>> +++ b/xen/include/xen/static-memory.h
>> @@ -1,13 +1,14 @@
>> /* SPDX-License-Identifier: GPL-2.0-only */
>>
>> -#ifndef __ASM_STATIC_MEMORY_H_
>> -#define __ASM_STATIC_MEMORY_H_
>> +#ifndef XEN_STATIC_MEMORY_H
>> +#define XEN_STATIC_MEMORY_H
>>
>> #include <xen/fdt-kernel.h>
>> -#include <xen/pfn.h>
>>
>> #ifdef CONFIG_STATIC_MEMORY
>>
>> +#include <xen/pfn.h>
>
> This change looks a bit odd in the context of the patch. I guess this is
> moved because the include should not be used if !CONFIG_STATIC_MEMORY? I
> am fine if you want to keep it here. But it would be worth mentioning in
> the commit message.
Yes, I did want to mention this change but clearly forgot. Will add (on commit).
~Michal
|
