Re: [PATCH 3/4] device-tree: Move Arm's static-memory feature to common

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 03/06/2025 11:03, Michal Orzel wrote:
> This feature is arch agnostic, thus move it to common.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
With one remark below:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

[...]

> diff --git a/xen/arch/arm/include/asm/static-memory.h 
> b/xen/include/xen/static-memory.h
> similarity index 93%
> rename from xen/arch/arm/include/asm/static-memory.h
> rename to xen/include/xen/static-memory.h
> index a32a3c6553bc..e445aa80578c 100644
> --- a/xen/arch/arm/include/asm/static-memory.h
> +++ b/xen/include/xen/static-memory.h
> @@ -1,13 +1,14 @@
>   /* SPDX-License-Identifier: GPL-2.0-only */
>   
> -#ifndef __ASM_STATIC_MEMORY_H_
> -#define __ASM_STATIC_MEMORY_H_
> +#ifndef XEN_STATIC_MEMORY_H
> +#define XEN_STATIC_MEMORY_H
>   
>   #include <xen/fdt-kernel.h>
> -#include <xen/pfn.h>
>   
>   #ifdef CONFIG_STATIC_MEMORY
>   
> +#include <xen/pfn.h>
This change looks a bit odd in the context of the patch. I guess this is 
moved because the include should not be used if !CONFIG_STATIC_MEMORY? I 
am fine if you want to keep it here. But it would be worth mentioning in 
the commit message.
> +
>   static inline void init_staticmem_bank(const struct membank *bank)
>   {
>       mfn_t bank_start = _mfn(PFN_UP(bank->start));
> @@ -46,7 +47,7 @@ static inline void init_staticmem_pages(void) {};
>   
>   #endif /* CONFIG_STATIC_MEMORY */
>   
> -#endif /* __ASM_STATIC_MEMORY_H_ */
> +#endif /* XEN_STATIC_MEMORY_H */
>   
>   /*
>    * Local variables:
Cheers,

--
Julien Grall