[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Tue, 3 Jun 2025 13:23:07 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FG+Z8Mhu8hlN7FD6BVQCjltYY7rSLo65HFJ9aJ8JZec=; b=EHA4mwWf0V4Rg+vrAljR/3aP6NcVXVCoH8wo1A3zW5TDEhauQilZNaOVF6uVxpvi1FjshQX9blDFosuZNdzZeipEpyaRtjcXZJCeZG8hZKrFOcoMdnm7sTBlJKB61Q0PeGYtX/APzDFl67jXb0Agvv8Cu12eAiQ40ko4BPzyYkTTjgZiEqWX6GWptrJx8LCEwoI1TT6LpyNUdRBIXj7NXAxvLoMcXHVlH57j51gOSeHVtcbe1/xm4DnwOTKJz9fShah0sLz5KVcuxcB+JTi5XtdBLg2Ek89fPug4h9ZRPVedrrWtJvpnfU9D2xhz4x1M0pQMPzatPuuknT2bN6I5wQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o84j+i3pKNPmrfXT+YALSaqDIWtWCMj6RrQXwuObUBp6+XVbEV2cWeMCsmEcefZFJZvbCQkUr5oECtGh4BuAwB+KSqoT12DC6Rz72p1pi33eajZZ6HBHsCCYGVzLqYiowRJeDb1vIt0JBoeeEVsEm1uRj2CCAHPe6gJPphTI0qzgOFRPXrOkZ5H/4FJdZSDWG0YwKTKbZsdNjQ1TU7TECDSStghzEcSX6dcsOhV3DXGaVsfbD2PhCrZ0MsQknIjXh6OTNC51euim1y6/QP5FKnI3q+T9sTlm5BNVgeWwaqccvmWcOaS0FDh4ZvDQzAtaUKVT5rfSbjbJ/wHSiXo8aw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Tue, 03 Jun 2025 11:23:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 03/06/2025 12:30, Roger Pau Monné wrote:
> On Tue, Jun 03, 2025 at 08:52:38AM +0200, Orzel, Michal wrote:
>>
>>
>> On 03/06/2025 08:46, Roger Pau Monné wrote:
>>> On Mon, Jun 02, 2025 at 05:09:29PM +0200, Michal Orzel wrote:
>>>> These tests are supposed to run on target. HOSTCC can be different than
>>>> CC (when cross-compiling). At the moment, tests installation would put
>>>> a binary of a wrong format in the destdir.
>>>>
>>>> Fixes: e90580f25bd7 ("vpci: introduce basic handlers to trap accesses to 
>>>> the PCI config space")
> 
> Hm, it's unclear to me whether this is the correct fixes tag.
> Previous to:
> 
> 96a587a05736 tools/tests: Add install target for vPCI
> 
> The test was not installed on the host, and hence didn't need to use
> CC instead of HOSTCC (or at least that's my understating).
You're right. Without install target, HOSTCC could make sense there.
I'll change the Fixes commit.

> 
>>>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>>>> ---
>>>>  tools/tests/vpci/Makefile | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
>>>> index 9450f7593a41..1101a669e118 100644
>>>> --- a/tools/tests/vpci/Makefile
>>>> +++ b/tools/tests/vpci/Makefile
>>>> @@ -11,7 +11,7 @@ run: $(TARGET)
>>>>    ./$(TARGET)
>>>>  
>>>>  $(TARGET): vpci.c vpci.h list.h main.c emul.h
>>>> -  $(HOSTCC) $(CFLAGS_xeninclude) -g -o $@ vpci.c main.c
>>>> +  $(CC) $(CFLAGS_xeninclude) -g -o $@ vpci.c main.c
>>>
>>> This was already posted in:
>>>
>>> https://lore.kernel.org/xen-devel/20230313121226.86557-1-roger.pau@xxxxxxxxxx/
>>>
>>> And got no feedback.
>>>
>>> I'm happy for your change to go in, but you might also consider
>>> picking up the run target adjustment part of that previous patch.
>> You're the maintainer of this file. You should tell me what I need to do
>> unless you want to wait for Anthony feedback.
> 
> I would also add the chunk to adjust the run target if you use CC
> instead of HOSTCC.
Ok, will do.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.