[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Tue, 3 Jun 2025 08:52:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hzp8RN9hwOzJoIap6EqlJQLus6f0OAqb16klUeUD3kk=; b=yIRPF7yklAQZskocUUXzJj4Xyjt16L6/H4mFJb4bjpfA7/xCMy/+ShArti+I3MjNka82lcjyHANfCC8ffKmP6SqkMpM3xMzfISrDTv8lbfh79aQ7b6D0QcHOkw+z6nsF0t6wJCuxqlpYy12MYeSQEM9CD1x+QwUcNi4QO6kyGbe43Xg0Vpv8dux2EiG/klSk74f23vx7PHOWMkdkrQ4iwMpSv6/B+5DIn6t4zRBiyTEz+oAMXkGMSvDm6fIxSvaiOSfsImzT75O5cSgltxapfmitUMiku73J/ogysNjcK2Ce6VFVWRdmBbfiBKtTBQLuIlmnc5g72IA+QhyrCJt1Og==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jx8QXT/ub6qZy7qkt23+ZopCerFT6NFROephBWicB9YYLPBfSBkyBxU4RqmbcplKLTxwyKM35HcTWCMojUBXzKnGtuQHJr3+hYQ+5bB/Mt0zvc+gwAAVRVI1b9cSBwrDSn2A5hC7LcuVqoiXPRwLZAKX4T75XbixuEAHhm4SzBDgb5NYNvUfii9RnDOzf05s/mFTyZL9kyOXSQpwBpvI8EssyHVNEQX6QXceXkvabAlwJnQ/343LX3pYdY5z5Q38Aab6ilj1cZjOSLzGruHFX058h0jXt6ja0ixPj+zGUHp8uT/cVcp3QFOF4dNcBZUEexGjbZv4/CrkqzoFHcPQkw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Tue, 03 Jun 2025 06:52:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 03/06/2025 08:46, Roger Pau Monné wrote:
> On Mon, Jun 02, 2025 at 05:09:29PM +0200, Michal Orzel wrote:
>> These tests are supposed to run on target. HOSTCC can be different than
>> CC (when cross-compiling). At the moment, tests installation would put
>> a binary of a wrong format in the destdir.
>>
>> Fixes: e90580f25bd7 ("vpci: introduce basic handlers to trap accesses to the 
>> PCI config space")
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>> ---
>>  tools/tests/vpci/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
>> index 9450f7593a41..1101a669e118 100644
>> --- a/tools/tests/vpci/Makefile
>> +++ b/tools/tests/vpci/Makefile
>> @@ -11,7 +11,7 @@ run: $(TARGET)
>>      ./$(TARGET)
>>  
>>  $(TARGET): vpci.c vpci.h list.h main.c emul.h
>> -    $(HOSTCC) $(CFLAGS_xeninclude) -g -o $@ vpci.c main.c
>> +    $(CC) $(CFLAGS_xeninclude) -g -o $@ vpci.c main.c
> 
> This was already posted in:
> 
> https://lore.kernel.org/xen-devel/20230313121226.86557-1-roger.pau@xxxxxxxxxx/
> 
> And got no feedback.
> 
> I'm happy for your change to go in, but you might also consider
> picking up the run target adjustment part of that previous patch.
You're the maintainer of this file. You should tell me what I need to do
unless you want to wait for Anthony feedback.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.