[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 3 Jun 2025 08:54:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rehh2XqJS+vhfNjoqb5PhLq3EgCFsnfzArbiRlkYj2c=; b=bOS1FfrOyK8oyeG4t2ADaSsUNdjT6Wiue0WbyT60uh3sNucTuYenLA2XhwLcZJ7CnMNlxenv4w8ypCitooEVjOvNblPVXLDucwZRjfQgh/DoSE23ZQLmAxkV1ouEvN/4AvSOfmuFZ9fqNe5HlYRzPrV4Gft88nGVF6nfb5E38jDuWglke2+08YcAmTae6Shh9vMl9DxyKHwyUoBjEdXx7Suyd4d/kSF4wuOcPWfsz5T92gTlGI/Bl3gQxlkb86wna1AlTPI243dqOa7skvN7nRM8ELSuUnev4h7UQ2inzqc0Q4vbK7cGiZYgxZMbFNX/humdebKXYg1B14yDnU1V0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZDSpmaYI4UZEgvIfpDh89p8AVv+4WMAddlbO6LMq61APfFo6AyE37lF+QNP3R3O8HDa2bXyvxJGZ2G8R0fUkGRltdp1T+vqsM6q3kOF+bluGBf2T4vCkc2OtO4Yw2JbK958ePvO1nJ1Phwn75vmRZ/bwVXOEjna/Bs9DPP4VWtFWog7/tubmp4TqZLKUxsySq+b0C/DuLOUkGtzhrNUcfxhwYOh3eAo430uLWm0mS/NjLJKGdqDYc5t8hcWypsS6e3V6xYMr0jU2wUpfRSYBIfJbeqVGjVM82R/EUIWOPqxwl8Aqy5m6FXTQ4ISR0sDbLDCrx3hbFioprcI94Gw5TA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 03 Jun 2025 06:54:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02/06/2025 10:37, Jan Beulich wrote:
> On 27.05.2025 10:21, Michal Orzel wrote:
>> There's nothing Arm specific about this feature. Move it to common as
>> part of a larger activity to commonalize device tree related features.
>> For now, select it only for ARM until others (e.g. RISC-V) verify it
>> works for them too.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> I realize this was already committed, but ...
>
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -162,6 +162,14 @@ config STATIC_MEMORY
>>
>> If unsure, say N.
>>
>> +config STATIC_EVTCHN
>> + bool "Static event channel support on a dom0less system"
>> + depends on DOM0LESS_BOOT && ARM
>
> ... I think we should strive to avoid such arch dependencies; they simply
> don't scale very well. Instead (if needed) HAS_* should be introduced, which
> each interested arch can select. In the case here, however, perhaps
> DOM0LESS_BOOT alone would have been sufficient as a dependency?
What if e.g. RISC-V wants to enable dom0less but not static evtchn/memory/shmem
because there are some functions to be implemented and they don't want to do it
now? Protecting with just DOM0LESS_BOOT would not be sufficient here. I
understand we could define HAS_*. I did not think about it.
~Michal
|
