[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Tue, 3 Jun 2025 09:06:24 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KzHA8aNUoQ51r6qgLWtnZ4Rk2D5NHDuVcoTBZjKWNL4=; b=lyIutpzVHorVYH3XKKxU8gcSHFy3kGqFOfEjem19Mz5ZQThHt67uYTjUgoOQPEkAXe+8VRBWwxUT2bbS7LBKX2ox+bhMn30MZ1K/88tc1dkGwc0MDykNLq/6o1lFrkpbPUzLahN4bfkFOPmP2xtd7a5JWweqJdcc/3FgAUtJ7IUBE55NNcIU7wQr70BJ9wKYL4sKnAfF9WnHfhteQfpXzaD8boIPp5Jwwd8/Ni3YUhxtXFounFmU0ch17Bb/CRhWR/cH33To4KDxsW25sKwfjRcKgIkQYJtpJsMkxM+EsOZTU7ljjxZqLmw0BnpegqtNJWgsSGBqz1hLZzQmNHDczw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rf4+LKM2BnWbpHaZZaAL5oqreUIz0hHy817vCK3T5TYMP0y6SCJtWqLd6n4dQ3BWclX9hC/Nv9WpdIxBNmYSOzXJ501KXvnE+4EHt/7/pzUAuXrvGwLWpTYFIeFy3EpnwHinnCWwwkTbz3IpQlTvQqoiJQGSf9Hsg9ht5EdpQQ0NNK8wjm1A0aTuKkxwMkwiP4pnXlYN/YOWlkKcUW6h6F02iKqM1TmxdvcAjyOSS1X9yWxuhinKKr3Lo1008+M7fJ7aP2tnspEsn0L6r09WzKhMBM4oL4idVYDjm0lkkDbQNFBivtFszF6WBGP0rozHu+KmUExF/80pMz4rG+dQJA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 03 Jun 2025 07:06:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 03/06/2025 09:02, Jan Beulich wrote:
> On 03.06.2025 08:54, Orzel, Michal wrote:
>>
>>
>> On 02/06/2025 10:37, Jan Beulich wrote:
>>> On 27.05.2025 10:21, Michal Orzel wrote:
>>>> There's nothing Arm specific about this feature. Move it to common as
>>>> part of a larger activity to commonalize device tree related features.
>>>> For now, select it only for ARM until others (e.g. RISC-V) verify it
>>>> works for them too.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>>>
>>> I realize this was already committed, but ...
>>>
>>>> --- a/xen/common/Kconfig
>>>> +++ b/xen/common/Kconfig
>>>> @@ -162,6 +162,14 @@ config STATIC_MEMORY
>>>>  
>>>>      If unsure, say N.
>>>>  
>>>> +config STATIC_EVTCHN
>>>> +  bool "Static event channel support on a dom0less system"
>>>> +  depends on DOM0LESS_BOOT && ARM
>>>
>>> ... I think we should strive to avoid such arch dependencies; they simply
>>> don't scale very well. Instead (if needed) HAS_* should be introduced, which
>>> each interested arch can select. In the case here, however, perhaps
>>> DOM0LESS_BOOT alone would have been sufficient as a dependency?
>> What if e.g. RISC-V wants to enable dom0less but not static 
>> evtchn/memory/shmem
>> because there are some functions to be implemented and they don't want to do 
>> it
>> now? Protecting with just DOM0LESS_BOOT would not be sufficient here.
> 
> Imo a transient(!) "depends on !RISCV" would in principle be fine, if ...
In this case, how can I know that upfront? When moving a feature I need to put
some dependencies. At that point I don't know RISCV, PPC plans. The only thing I
know is that I tested this feature on Arm. So the only meaningful dependency is
& ARM.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.