[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/19] xen: Add missing forward declaration to btcpupools_get_domain_pool_id
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 2 Jun 2025 16:05:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6My3KMxVFugVEvBPx0UL+Q4+Bwlp665qYLXsuj5ZfM=; b=yUScKXCtfaRq4C9eVgClzv6ldWW7hWLxrBGkV5QJP0Kha8RW+iT0UCfPu15YpFOp0FG4U1A7Ndi4/35CG3Zs/ChBU3B5tMris+m/zAlU4kO8ycuDKHb8rI+6Y6cbU0eWlRdHfv5qXmj/uWQgxG2xEq69xoiXdA0uHjZl4tHY4J60CV1RqnE7VFTIhRe9ffIAMkK+x+XQVM4PjT+iVt6inH0mffHDUx6+5iF88mUTmheuTJBh9wyQm0F5R6nmhvXiEXliGT1rAOWDDFUEFHoXIpW1zrBMYLECxlL6offaPWPfEloKEmt+M29Xb95ahPwlhOUIaVC95wSRXHifVhkqzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dAv4ndAwkNUQaKHDIf0oFLkoN5KOE+54FDO+JK9Hc/8+sfZd5xMGWDn73nINaeoMzx1cvRbqDlso+ELQ1l9IApvgVg+IfAP2MOeMdQLf3v51K/e5iYVeaG4xlKtsoAUCMEK+FtyVAmiAP79W+k2kXlHJRfP8AielTrRTXTpGmX6czL0xhiCtB/svHXdgTCmQbnWY8rKqzOX0yqHLML6ciTndPhBaZTpan8nwyyEWVBIEqZVwGsMKModUfar0pbPrSXb+cfaFIEGLa3V58hAQPKk2GkuFNwkp3nTribaYP2pFxwM5e2S5m6suMraeFn3KAM6VwZC1ymkEPvzt+m+3kA==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 02 Jun 2025 14:06:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat May 31, 2025 at 2:46 AM CEST, Stefano Stabellini wrote:
> On Fri, 30 May 2025, Alejandro Vallejo wrote:
>> And remove the ifdef guard, as it's inconsequential.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>> ---
>> xen/include/xen/sched.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index 559d201e0c..b5a6a22c7f 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -1291,15 +1291,15 @@ static inline unsigned int
>> btcpupools_get_cpupool_id(unsigned int cpu)
>> {
>> return 0;
>> }
>> -#ifdef CONFIG_HAS_DEVICE_TREE
>> +
>> +struct dt_device_node;
>> +
>> static inline int
>> btcpupools_get_domain_pool_id(const struct dt_device_node *node)
>> {
>> return 0;
>> }
>> -#endif
>> -
>> -#endif
>> +#endif /* !CONFIG_BOOT_TIME_CPUPOOLS */
>
> Usually the commend would just be /* CONFIG_BOOT_TIME_CPUPOOLS */
> without the !
True, my bad. I think I've seen both styles around (e.g: arm/include/asm/pci.h),
but it's true this one is more prevalent.
>
> Other than that:
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thanks!
Cheers,
Alejandro
|
