[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/19] x86: Add missing pci_dev forward declaration in asm/pci.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 2 Jun 2025 16:01:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ld1S+SP5zIa3cFaYHbDba9acNH4nT5mVLdFuQSLkneE=; b=CXtZzVtwqMg4K06Tnh7PyPReoaF8z55SfFITVuNcabGhhYTjWUO0Rvo3QFQwdAFNmMU19dMCOQAKu0ODzdsZI8BWhqpHMqTlT36ucVxW99ufBjq4SDaoBf4RUVCNtd6BeTiztuehA+xsLQ8exFPJMUtQX7k0At9RCd88IZxpAnSMBdG9a2acHP+V30zDqbPHFd5tFef6Y0wRnj4CB2+NHp54U71hBhnik5FHPgECcu3Qa6ZueLViUjk1oWWCZ29S48OOrrOiv1HAvsn2wei92BQpNxc01gus9hLbc+TT2gi5RTCjBNwjL9h4Bwy1SWLpq44EgfeVC/401NAfnU/b5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=chy0kpLjGVdV8WkiiBwAegRUIvwCVNk9pivzdoh/iYVxMgGzqQCjIlCy4jhEXy1q5/y5kMRyjb5xbn4Y/J38gGWAPLWkGiQENJwB7c09SBxP2a5iQpPtrG5N2UoOa0NzSZVjmwA9RbkH5mTCSq/segOZ0ZX+oytA08arlwuvazDTF6BvigsG7gxXOsQpQ5ay/g8lKiWbHPvHM1XnWL2+nV1oV1uZZuGWoqCyHOTI9QC45BZDjFDZLT+IE8j1gHwsCe2R6AtXe34T5IUjUvRXA+y9LNK4xJlY96MjsXE5zOsAGvjOsOlXRpwkqjCAsAWOKT5Q7ZhqseSw69lLfSkWKA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 02 Jun 2025 14:01:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Jun 2, 2025 at 9:48 AM CEST, Jan Beulich wrote:
> On 30.05.2025 14:02, Alejandro Vallejo wrote:
>> --- a/xen/arch/x86/include/asm/pci.h
>> +++ b/xen/arch/x86/include/asm/pci.h
>> @@ -13,6 +13,8 @@
>> || (id) == 0x01128086 || (id) == 0x01228086 \
>> || (id) == 0x010A8086 )
>>
>> +struct pci_dev;
>> +
>> struct arch_pci_dev {
>> vmask_t used_vectors;
>> /*
>
> Would it perhaps be better to put this ahead of xen/pci.h's #include, thus
> helping all architectures?
>
> Jan
You mean include asm/pci.h from xen/pci.h ? Seeing how arch_pci_dev is here it
must already be transitively included. I could replace all asm/pci.h with xen/
pci.h instead, but this seems strictly better so you can include asm/pci.h when
that's all you need.
Or did you mean something else?
Cheers,
Alejandro
|
