Re: [PATCH v1 3/3] xen/dom0less: move make_chosen_node() to common code

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 13/05/2025 15:45, Orzel, Michal wrote:
> On 13/05/2025 16:29, Oleksii Kurochko wrote:
> > The current implementation of make_chosen_node() does not contain any
> > architecture-specific logic. Therefore, move it from arch-specific
> > files to common code.
> >
> > At this stage, there is no need to introduce an arch_make_chosen_node(),
> > as no architecture-specific customization is required.
> >
> > This change avoids duplication and simplifies future maintenance for
> > architectures like RISC-V and ARM.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> [snip]
>
> > +/*
> > + * This function is used as part of the device tree generation for Dom0
> > + * on ACPI systems, and DomUs started directly from Xen based on device
> Might be worth adding (on Arm) after 'ACPI systems'. Could be done on commit.
Please don't. This will become stale otherwise as soon as RISC-V is 
started to use it. Instead, we should say (on platform where CONFIG_ACPI=y).
Cheers,

--
Julien Grall