[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/3] xen/dom0less: move make_chosen_node() to common code
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 13 May 2025 16:45:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ed5VZ817fd+x83PGoGdBckLlmamInLqMfiGZajgcKBo=; b=F/WX62OSPqdZKo45JleFRE7jHsM7/jXWuMNGY07J+f+uj40LGXqj9vfvBZZHxXG3rlzbmwgNIH8WOrU+/zgyX27wkJ+cIf0jB2e0eb+RtSWgA6u7DXqRYSApjisVt4KBTuKRb92MbzAPKeIXs33M9MuOv61auv9U/sfZEIFPRfb0IsQtTi8swU2LkOej84eVpDrP1De4pDCco7Jh58zMw6GIGhy7/aWFdxBtuSHAI/7K7C5BSdLEOUrnklfxRQx+QIs21FxM0ouiO2H2xuHpb+DwB6frZFOuj9Ep0CrT52j2pUhaAn4sVIECyP49lbSPz8PXyl8308JJ08mzkSCnUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=edqnZ3MY/MBBtbR6XTurTeuMhN+6N3QJu/80QSyp1FAwrpLZgqIDMWvoQM76R0xiqPR8Dw3G7x2tLXO4J66+TsAWn/B3dLKW+2vLQsEqA1Max04JCa2RWLmGqmVuc5WDsnhDA66zlIxCPy/RlzauXl6dN2NuYIzQajhAAa1BgJKMU30WPfhaALbO2rOqiowcF6UxzjVc7bulqJ6FqZmpFgi1AlsPY21csXTfTa7/wgqlfHUYZqwd8cd8TGLYGfVTdfXY2GIMGlb0dwV4N0wgoBL00ZUrfpgvPdaus4FRi8AskNXeDAhbwHObGdWTTnljiDcmjfh/8QfcSZNpmk/hYg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 13 May 2025 14:46:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/05/2025 16:29, Oleksii Kurochko wrote:
> The current implementation of make_chosen_node() does not contain any
> architecture-specific logic. Therefore, move it from arch-specific
> files to common code.
>
> At this stage, there is no need to introduce an arch_make_chosen_node(),
> as no architecture-specific customization is required.
>
> This change avoids duplication and simplifies future maintenance for
> architectures like RISC-V and ARM.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
[snip]
> +/*
> + * This function is used as part of the device tree generation for Dom0
> + * on ACPI systems, and DomUs started directly from Xen based on device
Might be worth adding (on Arm) after 'ACPI systems'. Could be done on commit.
~Michal
|
