Re: [PATCH v2 2/6] docs: remove qemu-traditional support from documentation

[Anthony PERARD <anthony@xxxxxxxxxxxxxx>]

On Tue, Apr 08, 2025 at 02:35:20PM +0200, Juergen Gross wrote:
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 7339c44efd..ccf0c58895 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -895,12 +895,6 @@ is used.
>  Specifies the path to the X authority file that should be used to
>  connect to the X server when the B<sdl> option is used.
>  
> -=item B<opengl=BOOLEAN>

This `opengl` sub-option is also mention above, for the `vfb` option.

> -
> -Enable OpenGL acceleration of the SDL display. Only effects machines
> -using B<device_model_version="qemu-xen-traditional"> and only if the
> -device-model was compiled with OpenGL support. The default is 0 (disabled).
> -
>  =item B<keymap=LANG>
>  
>  Configure the keymap to use for the keyboard associated with this
> @@ -1215,17 +1209,14 @@ working graphics passthrough. See the 
> XenVGAPassthroughTestedAdapters
>  L<https://wiki.xenproject.org/wiki/XenVGAPassthroughTestedAdapters> wiki page
>  for graphics cards currently supported by B<gfx_passthru>.
>  
> -B<gfx_passthru> is currently supported both with the qemu-xen-traditional
> -device-model and upstream qemu-xen device-model.
> +B<gfx_passthru> is currently supported with the upstream qemu-xen 
> device-model.

I don't understand why this is written in the doc :-(, where is it not
supported? Previous revision had: "only supported on qemu-trad, no
support for qemu-xen" which was useful information, and was changed
later when qemu-xen gain support. I would remove the sentence.

>  When given as a boolean the B<gfx_passthru> option either disables graphics
>  card passthrough or enables autodetection.
>  
>  When given as a string the B<gfx_passthru> option describes the type
>  of device to enable. Note that this behavior is only supported with the
> -upstream qemu-xen device-model. With qemu-xen-traditional IGD (Intel Graphics
> -Device) is always assumed and options other than autodetect or explicit IGD
> -will result in an error.
> +upstream qemu-xen device-model.

Here, we can remove the "Note that this behavior is only supported with
qemu-xen dm", this is the only device model supported so I hope the
behavior is supported in this case...

>  
>  Currently, valid values for the option are:
>  
> @@ -1903,10 +1894,7 @@ it may be useful to request a different one, like UEFI.
>  
>  =item B<rombios>
>  
> -Loads ROMBIOS, a 16-bit x86 compatible BIOS. This is used by default
> -when B<device_model_version=qemu-xen-traditional>. This is the only BIOS
> -option supported when B<device_model_version=qemu-xen-traditional>. This is
> -the BIOS used by all previous Xen versions.
> +Loads ROMBIOS, a 16-bit x86 compatible BIOS.

This option is not valid anymore, libxl will complain with:
    "qemu-xen does not support bios=rombios."

And I have no idea if it can work on not, I just know that XenServer
still use RomBIOS with a patched QEMU.

>  =item B<seabios>
>  
> @@ -1926,8 +1914,7 @@ Override the path to the blob to be used as BIOS. The 
> blob provided here MUST
>  be consistent with the B<bios=> which you have specified. You should not
>  normally need to specify this option.
>  
> -This option does not have any effect if using B<bios="rombios"> or
> -B<device_model_version="qemu-xen-traditional">.
> +This option does not have any effect if using B<bios="rombios">.

This doesn't seems to be true. I think the only way currently to have
`bios_path_override` been effective is to start a guest with type=hvm
and device_model_version=qemu-xen.

So maybe instead we should write "Requires
B<device_model_version="qemu-xen">." like we have for the bios=ovmf option.


Thanks,

-- 
Anthony PERARD