Re: [PATCH 1/2] tools/xen-hptool: Add missing newlines

[dmkhn@xxxxxxxxx]

On Wed, Apr 23, 2025 at 05:28:20PM -0400, Jason Andryuk wrote:
> Add some missing newlines to error messages.
> 
> Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces")
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx>

> ---
>  tools/misc/xen-hptool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c
> index 6d6aec8bad..d850404e31 100644
> --- a/tools/misc/xen-hptool.c
> +++ b/tools/misc/xen-hptool.c
> @@ -51,7 +51,7 @@ static int hp_mem_online_func(int argc, char *argv[])
>      ret = xc_mark_page_online(xch, mfn, mfn, &status);
> 
>      if (ret < 0)
> -        fprintf(stderr, "Onlining page mfn %lx failed, error %x", mfn, 
> errno);
> +        fprintf(stderr, "Onlining page mfn %lx failed, error %x\n", mfn, 
> errno);
>      else if (status & (PG_ONLINE_FAILED |PG_ONLINE_BROKEN)) {
>          fprintf(stderr, "Onlining page mfn %lx is broken, "
>                          "Memory online failed\n", mfn);
> @@ -82,7 +82,7 @@ static int hp_mem_query_func(int argc, char *argv[])
>      ret = xc_query_page_offline_status(xch, mfn, mfn, &status);
> 
>      if (ret < 0)
> -        fprintf(stderr, "Querying page mfn %lx failed, error %x", mfn, 
> errno);
> +        fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, 
> errno);
>      else
>      {
>               printf("Memory Status %x: [", status);
> --
> 2.49.0
> 
>