Re: [PATCH] xen/vpci: Fix msix existing mapping printk

[dmkhn@xxxxxxxxx]

On Wed, Apr 23, 2025 at 05:22:29PM -0400, Jason Andryuk wrote:
> The format string lacks a space, so mfn and type run together:
> (XEN) d0v0 0000:06:00.7: existing mapping (mfn: 753037type: 0) at 0x1 
> clobbers MSIX MMIO area
> 
> Add a space.
> 
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx>

> ---
>  xen/drivers/vpci/msix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index f3804ce047..499810b238 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
>                  put_gfn(d, start);
>                  gprintk(XENLOG_WARNING,
>                          "%pp: existing mapping (mfn: %" PRI_mfn
> -                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
> +                        " type: %d) at %#lx clobbers MSIX MMIO area\n",
>                          &pdev->sbdf, mfn_x(mfn), t, start);
>                  return -EEXIST;
>              }
> --
> 2.49.0
> 
>