[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] vpci: Refactor REGISTER_VPCI_INIT
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Wed, 23 Apr 2025 03:49:37 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=heckH4zwfJlPex+mRGYYqXGFR9rnvefybkN6MR4COvw=; b=HIoH7KNn/uSBCGjSOhWLYzVYfUR0ARQ4mufopoFMQJjIkGOcuKVJ4nz5vDn9HBYTTz87GIB8nazUf508myXwgzPXNo2RuCoJF5wI8syza15wHf56v2j+tMiiiyhB+0Gv9y9Rz1u2edeWJb85yGspF2eLRLHtbuMxDNmjpW+QSBeHXIc+9m1zxqvWkbzmYkBD1L4X42zSLFkt108CcfAS3DZb/a2DT2zGRxwAT3wbzq+qXISA0infMo0lFT9UxpbdghrZMyRINz70C35bwXCRzaTuDA7j2taLfyrd2CUnwl30XYj0LmMjSbLRcEdVytoiTk4BOQA6BwbilZfL0stqHw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lOxPf5Fjh0OnIZpXdTgngW5TD7x63oEeJ4FQnYllEWowX0U6ingtcXfOQOMrddri+GG80zJCY4FE6R+CfnObKpSu3XGvnhCjgIs81iBvhs05hqrEzdGD5cmbTLqjrGCNATUc7+F+C4iDiFX61nh9Q8Hk2eN1eHA0KaDYcWzOV9KCqYEBVUgerHqqwC7YzFkdrSr219kXj5KNo1xT+dKHD++4zxpaRPfGMy7PvKp/1YZnsmdhPZzz9aGfdTsTHkHxL81Dq4+bSfg790Qu6D9LSUT9uLFbemyFqUy9DMk5ZH+baoCNFMCxA/1Kci+bu4VLMJI/Zp6pZwtcEXnKwu8CeQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Wed, 23 Apr 2025 03:49:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbsoVaTdJd8UN3wUOnIdqQLAHMILOv2xuAgAFJegA=
- Thread-topic: [PATCH v3 05/11] vpci: Refactor REGISTER_VPCI_INIT
On 2025/4/23 00:03, Jan Beulich wrote:
> On 21.04.2025 08:18, Jiqian Chen wrote:
>> Refactor REGISTER_VPCI_INIT to contain more capability specific
>> information, this is benifit for follow-on changes to hide capability
>> which initialization fails.
>>
>> What's more, change the definition of init_header() since it is
>> not a capability and it is needed for all devices' PCI config space.
>>
>> Note:
>> Call vpci_make_msix_hole() in the end of init_msix() since the
>> change of sequence of init_header() and init_msix().
>> The fini hook will be implemented in follow-on changes.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>
> From the description I can't derive the need for ...
>
>> --- a/xen/include/xen/xen.lds.h
>> +++ b/xen/include/xen/xen.lds.h
>> @@ -187,7 +187,7 @@
>> #define VPCI_ARRAY \
>> . = ALIGN(POINTER_ALIGN); \
>> __start_vpci_array = .; \
>> - *(SORT(.data.vpci.*)) \
>> + *(.data.vpci.*) \
>> __end_vpci_array = .;
>> #else
>> #define VPCI_ARRAY
>
> ... this change.
As I understand this, this is used for initializing all capabilities according
to priority before.
That is msix > header > other capabilities.
My patch removes the priority and initializing all capabilities doesn't depend
on priority anymore.
So I think this is not needed anymore.
Do you mean I should add some explanation in the commit message?
>
> Jan
--
Best regards,
Jiqian Chen.
|
