[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 02/13] kconfig: introduce domain builder config options


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Alejandro Vallejo <agarciav@xxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 17 Apr 2025 11:39:15 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lRrsTGlM8jDk5NfX+04uV6Dn1dCgfBpnKsjcSs9c7pg=; b=DOj5sCjJUb1UZ8eYWtWzWLzfYJwprJS1GHQgvamX4QahDDPOohrp2PgkkELDyM86E1FZbOt43YV0xVTuN9pr5S9Bkj6vuFwKYuYXGhpZvy7ENlBMnaUND7IVsdCd+THGsKsZTI/TAItOic4qvKV866NfN08pcln8taKyLm9kDWdQucNthHBh7ZAZHDYHm0RwdFGeLDXhPKBV4+TK0YRu70z92Go5T0M2I7HReFtMI+Hu4brDymiT+GDIZ3zQuLfZvzpPvk0ZYtMS6YTjQqd8iGF1lsdq8dix61OZIWwQAgu6LD6inJ3BTW/BVMfoabRvdu0sJjN2aMhHHZgp5/llGw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ni+6yKYdelh8EFJ9KCJPwqMTjFc2nNNsU1GxPYqaV/SaI0wsDv2Ji05kgv+y9IsYrJ0XFCmzNBbpA1xIF7wFfSRCLE1XZSsImjtANFv3BmpuMo+oryvt96SGEgLgL/9Du30xYEbkyzEyGkwUP7Pfg79Ee3HZSnAWHBjUH75M+jlM8SoYAo2yglnXYDINS0Psm14sfxADuTS9hIm3fu7js4aqihKj3eVC5jSf3+xQzbicaq/8bpYz0saCZqIb/vA2JqcSFje+tThFmvtB5Ctn6wLiS8dVXg+WL7Gj+z0M6YSf3kRTG5R3ey5WpGn5RTuveDh5MScDZSaAD00NYv0JVw==
  • Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Michal Orzel" <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 17 Apr 2025 15:39:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-04-17 11:00, Jan Beulich wrote:
On 17.04.2025 14:48, Alejandro Vallejo wrote:
--- /dev/null
+++ b/xen/common/domain-builder/Kconfig

+       bool "Domain builder (UNSUPPORTED)" if UNSUPPORTED
+       select LIBFDT
+       help
+         Xen has a built-in mechanisms to automatically construct domains
+         (like dom0) during the boot phase. The domain builder is an enhanced
+         form of that mechanism to enable constructing predefined domains
+         described on a flattened device tree.

I'm not a native speaker, but (perhaps because of that) "on" here reads
odd. More logical to me would be "by" or "via".

Yes, "by" is better.

The description is a little backwards - it should state what it is first. Maybe:

Support for constructing predefined domains described by a flattened device tree. This allows constructing multiple domains at boot time instead of being limited to a single dom0.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.