[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] xen/arm: Move some of the functions to common file
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 7 Apr 2025 15:07:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pJtNDAXxMGk19V9Jad22uspR6AzaHK6S4wYHXiJ0EDk=; b=tNCEjf0sygohjBupV+dMl0Kk554L5USD9qOBgdOImSZp3JVg6f2C8GpVEciNcjoJPLF9SpW4HEuzxbi2V2+Bg2iosLilCuWpevv6xGXhaNxBBkt4PrY1X6jqfvxXp+liGMWbTDE5HVwrjhp3w/OQymz0jjSh2EYznSZqkQCPT6T10aDKrNU63T8L7CsdO15oy+ha21OWXiVLh4oZ5btU7e4Zo3zJEampl2x3qSKJmy4QTopLnbHiyMzCrdfEU5GiaThcJsVuKta2t6DlcW3djvJKaoqse1wL1dvv6rkKeZ7E69uz/3+AXuboU4X8rqGnk2qUMjmK52DCP6ysNbcu/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ly9wwJBc0GmW1dR9ZbBVr0RooX9HYL2DhjWvs9MARYQV06NqkCZIiY1V6I5Op9Pjr5/P6Ef2dvcG4GEnwGGJU3/+Nt6hNnvTEDdIBsQfAZVAGfWQwzbFi7wodMCJ43/MzJss7lHXOv/jv6d+ihrtAA+e94YktYTaL1UvYqI7DHU9OvqV2oGel7/kJjCc7Eo5TPJ/+26oOJ0plD35pURR7SrwKX8x6AlhA6UEzKGnEZqHs9kVw0j0KJd3iqx98WA2tUzgjj7kpUKhlx+41sFTU+h2w8c8GpDro9HqCV4K9awF6/b3gjSJwhOPMSAcuKN4ua2h3Ydmh1CSNDQJlgwrZg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Orzel, Michal" <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 07 Apr 2025 14:08:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07/04/2025 14:31, Luca Fancellu wrote:
Hi Ayan,
Hi,
On 7 Apr 2025, at 14:18, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
Hi Michal,
On 07/04/2025 10:04, Orzel, Michal wrote:
On 03/04/2025 19:12, Ayan Kumar Halder wrote:
Added a new file prepare_xen_region.inc to hold the common earlyboot MPU regions
configurations across arm64 and arm32.
prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
arm64. Thus, they have been moved to prepare_xen_region.inc.
enable_secondary_cpu_mm() is a stub which is moved to prepare_xen_region.inc as
SMP is currently not supported for MPU.
This does not sound right. If you want a place to keep some common MPU stuff
between Arm64 and Arm32, you need to come up with better name for a file. SMP
has nothing to do here with preparing regions so it feels odd to have
enable_secondary_cpu_mm stub there.
Can I rename prepare-xen-region.inc to mpu.inc ?
Julien/Luca - any thoughts ?
I would say we leave the SMP stuff out from the common file, at some point we
could start working on the
SMP support and maybe there would be difference between arm64 and arm32.
Do you want to duplicate enable_secondary_cpu_mm() in arm32 and arm64 ?
I am fine with that.
what about common-cpu.inc?
Sounds ok.
Michal or Julien should comment as well.
- Ayan
Also, new files should use dashes '-' and not underscores '_'.
Ack
- Ayan
~Michal
Cheers,
Luca
|
