[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] xen/arm: Move some of the functions to common file
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 7 Apr 2025 14:18:52 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZ6/LOFjefTGrm3j8n8RlL29yYD154ZWaaSVmydopgo=; b=WdqPDKEcN0QmC0ZkdRmCDNBj4wGlQFXv+EkRBf3UYwM22Q0d17gT13BN+Lx8E24w4rOIbV/t0IfnHyQ22U20Wkxgr03D4O8i7ptMYRv2KdF++kVDMfncy/7YOwseVqfEm45kYIuhRQG50W1f3vEUgkBeqZnU+0fP8AKhPRY50eYwrStBNEidpxm0VNPa+8iZ9Uhu06yZzuzPOvfHolaT+afKMOxXqT7ElqfrdHGThAKtEt4BhSFhRRMo9/3eyfE6RNxhrssOYVoQZYzPatNroJOSQqWP19BsLPmlyxVuDy5DjhYy4FEe6H5zESX1ieGy4gU7kDwUqAjrqb6hhOwk1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hoyZ1shOJyGXgDXqz0qh5L+BO5ABrbYmuKw4538558mcTnCAoYkS+R1XPGbr5uKna1ymcQvQJaNTSF/5xe0rPkjsrRssj140dlr2czlrfWHf7nbTGvPG9biMqtW1Pz+97KReaBLhPJazibMIPMrGCtkCKHwEoI/r0cCiQMd+m8psT04Jqo3FEgQIO5fWIaJIRd5QPDy/HrUo5RrJqoI+1UkYDaaEUdMeSgo4u06jZGGpb2N5DUVVvH05H1zmwRh0eGregUvVqeVbILDnVp77VcIRR1PB9q690vu9Y1UI6xenQQ8N+1+D6UcAFSlDnBp398+uiBP32pPCUAyC1y7HlA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 07 Apr 2025 13:19:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On 07/04/2025 10:04, Orzel, Michal wrote:
On 03/04/2025 19:12, Ayan Kumar Halder wrote:
Added a new file prepare_xen_region.inc to hold the common earlyboot MPU regions
configurations across arm64 and arm32.
prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
arm64. Thus, they have been moved to prepare_xen_region.inc.
enable_secondary_cpu_mm() is a stub which is moved to prepare_xen_region.inc as
SMP is currently not supported for MPU.
This does not sound right. If you want a place to keep some common MPU stuff
between Arm64 and Arm32, you need to come up with better name for a file. SMP
has nothing to do here with preparing regions so it feels odd to have
enable_secondary_cpu_mm stub there.
Can I rename prepare-xen-region.inc to mpu.inc ?
Julien/Luca - any thoughts ?
Also, new files should use dashes '-' and not underscores '_'.
Ack
- Ayan
~Michal
|
