[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/char: implement suspend/resume calls for SCIF driver





On 28/03/2025 09:13, Orzel, Michal wrote:


On 28/03/2025 09:57, Julien Grall wrote:


Hi Michal,

On 28/03/2025 08:39, Orzel, Michal wrote:


On 28/03/2025 08:08, Mykola Kvach wrote:


From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

The changes have been tested only on the Renesas R-Car H3 Starter Kit board.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
I'm afraid that without a suspend feature on Arm merged, this is just
introducing a dead code which we try to eliminate both for MISRA and safety.
I'd prefer to wait for the suspend feature to be merged first.

This patch is not different from the ns16550 driver which already have
suspend/resume callback and users. They will be used by but the caller
is not used on Arm yet. So you are saying the code there is not MISRA
compliant? If so, is this reported by ECLAIR?
NS also works for x86 that has suspend feature. SCIF only works for Arm that
does not have suspend feature.

I don't understand why it matters that NS16550 is used on x86. In previous MISRA discussion we said the violations were tracked per arch rather than globally.

[...]


Regardless that, I don't think the full suspend/resume series would
help. AFAIR, the caller will be protected with a config (SUSPEND
something). So IIUC your definition, this code will still be "dead code"
in certain config. Therefore are you suggesting to protect everything
suspend specific code with SUSPEND?
I'd say so, yes.


If the answer is yes, how about introducing the SUSPEND config now? This
would allow to get some of the code merged in advance.
Better this than nothing. But in case of this patch, why would we take it anyway
without suspend feature?

Two reasons:
* There is nothing really preventing the SCIF to be used on x86 (yes I know there are only Arm HW today) * We will likely want to commit the series bits by bits to avoid dozen of patches to be sent everytime. This patch is something small enough and can be committed before hand.

I'd prefer to add SUSPEND config and protect existing
code i.e. NS that can work on x86 but not on Arm, etc.

I am fine if we want to add the SUSPEND config first.

Cheers,

--
Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.