Re: [PATCH] xen/char: implement suspend/resume calls for SCIF driver

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 28/03/2025 08:39, Orzel, Michal wrote:
> On 28/03/2025 08:08, Mykola Kvach wrote:
> > From: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> >
> > The changes have been tested only on the Renesas R-Car H3 Starter Kit board.
> >
> > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> I'm afraid that without a suspend feature on Arm merged, this is just
> introducing a dead code which we try to eliminate both for MISRA and safety.
> I'd prefer to wait for the suspend feature to be merged first.
This patch is not different from the ns16550 driver which already have 
suspend/resume callback and users. They will be used by but the caller 
is not used on Arm yet. So you are saying the code there is not MISRA 
compliant? If so, is this reported by ECLAIR?
Regardless that, I don't think the full suspend/resume series would 
help. AFAIR, the caller will be protected with a config (SUSPEND 
something). So IIUC your definition, this code will still be "dead code" 
in certain config. Therefore are you suggesting to protect everything 
suspend specific code with SUSPEND?
If the answer is yes, how about introducing the SUSPEND config now? This 
would allow to get some of the code merged in advance.
Cheers,

--
Julien Grall