[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MINI-OS PATCH 1/2] 9pfs: add fstat file operation hook


  • To: Jürgen Groß <jgross@xxxxxxxx>, <minios-devel@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 20 Mar 2025 10:41:51 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lit5FYt34/fMOegMMpetsvbD/eP0pP1zDU5kMObxm0=; b=tQWKmjwvZhcgOKbCHI2P49rFPJ97s7Tky0LkorSrkPZhvG7J6ODpHoWIC3fhrK/fNCjgUwLO1S4eR0/SXeuWZgsz2itNOHwtFdcyRaGM4USntRYRttKialn2G6xjlexOOHtB4kAEIoWD//oSSa4U/F59YrVwSH9CVFp+Gi5Q/9Iwi9U742YKQQsoyFHmhQbjUxLvY84ftnGSPQGLz1UzAYnT1cEjTdyKVSjSqX06Y+i6BIqDoBvZnuJQosxsjBmHQNrTUON2eji2M7qq1RLFGcp1Wjdv6qjRXEQUxuRtQ10mNrnbD7z/9uAW/7+byqIW3djO2koyXg2aEtH1t/m9xg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SHB+2KsglvCLLOhwGeeUcByAS71qsmNgxAbNPRZMzZkaS3vD5rHzFw63PDQasfCRZkf1+sMrtdYvuRuF+CQi18+2cSzvCowrzYe0fNWNctG+ElCpLkDGtMxUBQwKXi1zffpziTfDt6dsyPJTGKYIXRimS8pY8z7BcGeqDyxkqsL3LLP+pSV1HrlauB6y78kKS4gPir4hVM7oo63tPVvZXz0+uhCip27ybn4UP5rKZiQAky4Gpeia7lrb7a31irKBvc6iHkYLeP8vBgAR49RHgRRKdOt8VTs8J9Pn4WNp4g2Jh/cx2tiB4WVKwgkXEJm//D+RmwWeTUxK68oGyvO6hw==
  • Cc: <samuel.thibault@xxxxxxxxxxxx>
  • Delivery-date: Thu, 20 Mar 2025 14:42:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-03-20 10:35, Jürgen Groß wrote:
On 20.03.25 15:28, Jason Andryuk wrote:
On 2025-03-20 03:49, Juergen Gross wrote:
Add a file operations fstat hook to the 9pfs frontend.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---

@@ -950,6 +952,32 @@ static int write_9pfs(struct file *file, const void *buf, size_t nbytes)
      return ret;
  }
+static int fstat_9pfs(struct file *file, struct stat *buf)
+{
+    struct file_9pfs *f9pfs = file->filedata;
+    struct p9_stat stat;
+    int ret;
+
+    ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat);
+    if ( ret )
+    {
+        errno = EIO;
+        return -1;
+    }
+
+    buf->st_mode = (stat.qid[0] == QID_TYPE_DIR) ? S_IFDIR : S_IFREG;
+    buf->st_mode = stat.mode & 0777;

I think you want `|= stat.mode & 0x777` here.

Indeed. Thanks for catching this one.

With that,
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.