[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 15/23] xen/xsm: Add XSM_HW_PRIV


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 17 Mar 2025 11:04:19 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Ll7WWcHIk5jMdkgWMJiBL2PgtHt1OJxUrcDlsr83cs=; b=u4kOhvCR96QuZL2nG3UBnvggpfMnWUaz1HuRieY0n3TbzG1uR63gF+6j3LwuO3t7HLKHlMSj1xelnl2SFiCJD9sKqj0+eUrJBvikyQSWRLcuhMYeBIVXhESrAVW/hJLj0ATOF5GqkkL8ZO4VpdY8UpBAXTS/x3R/G/1LvJQORF609YEZUI8h54ZToRmA/cN82UYQtfrg4zpE+ycaWOl1dvtzoUsGX57H6+p8RP08vpDguklHDv96jMlDfW5e2edr9jw6qJ3O5jLpxrD4rrEUkFCicNUlWabaikIu1VAJ123j3qZrla5r4K3lKCNUz/v0vuRsuvZWlKKyRg8ksOMdsQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PHTgssDo8HI649DclZAZDLBUfi/OeKZLw/I0+Tqmhu4ITZbc49tpHz6EgN0Z+4kTuJCqI4wDk0nY9c+jZkUs97z1fRMtfVz+R0elmjEK1Rm2lw0720CtV75V97IZ6KPqQnIKGBgx/KQG0rpFv8zF4yQJGkBK5ulDnCDZSQwsOcI5O5uo88gf6z1Hh8Lwivn+xK/Rg7F+3i/Mn+fpyKC79kZGgYvqe4di+dE53yz3jOmQb314+BESVrnt+5sOEOZC0uZ0mj5uzSGfuGuxiCS3TcskO+PeqLUSXBe0A7Io0HtaMZ1+c0TktY3xE46c8JIrRTinAjITxQG9dWKUfli9ZQ==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 17 Mar 2025 15:04:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-03-17 10:22, Jan Beulich wrote:
On 06.03.2025 23:03, Jason Andryuk wrote:
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -95,7 +95,11 @@ static always_inline int xsm_default_action(
              return 0;
          fallthrough;
      case XSM_PRIV:
-        if ( is_control_domain(src) )
+    case XSM_HW_PRIV:
+        if ( is_control_domain(src) && action != XSM_HW_PRIV )
+            return 0;
+        if ( is_hardware_domain(src) &&
+             (action == XSM_HW_PRIV || action == XSM_DM_PRIV) )
              return 0;
          return -EPERM;

Hmm. Isn't DM_PRIV a property applying to the control domain (besides
any stub domains), but not the hardware one?

I ran QEMU in hardware domain to provide devices to a domU. I thought QEMU would better run in hardware domain than control domain.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.