[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 6/7] xen: introduce Kconfig HAS_PAGING_MEMPOOL


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 17 Mar 2025 09:29:19 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLjayvwV+l3sJBls3Ax1BA2yCDD4U1EwskKnJNUiato=; b=TCaF5gxr6bBn5zXotZ1VwI5Zls1AmEm5wCigMcCISzBFgXt9SK/DKbc1GFXHPntC3Mcxj75l+ZSk9J7qovYqE9MXQiREaFZfOYxHb441UZIhCb9VG9qsvSy8rqnwzGxh6hXSdCYLNRitvUbRZYyKkdkytz4r3AfW/CyI1M4rz7LACiCyQigKKlDP8j4n5dotqh0wQS4lfmYOJBzvhEDl9qdd8wmwfLi9JAoWrU02XAd3hsYshNcDMSPB2qDoZvHNUHZtrn7OWQydCtxGntNAEpkCzvzk8RrDw8ki9/VfCtpkdqKfRN24IholfvWp3A2aQVUkqqiTb8Q33GbrGWIMiw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLjayvwV+l3sJBls3Ax1BA2yCDD4U1EwskKnJNUiato=; b=SVb/GaekJzEwFZXfc2wGo4kZm5JgE1mS2RH9/Ty/1BhBiegctXwKJLKXSCKyh8xslpWk0J6kiQoaNljqsP4beTMoxF2wRPuxxbZn73lMYtRKTzNY8wDb6lHXcN865+Ytf3qnbEcCXHY1HXI/SRZv87+7iqMx55dDv9CeDHkQVDU8i+oY92G+i17Indf7wpYYQU0gbYkgAyMOZnxkqfHwwLv6blcvAWz2+RhUsa55l6rFt/sktISgsUaDEmspAvqnoOdNFoeG8oaN53mfn+/WTsG3ISoaChdFB1wjc6W9jxQxHOaakDuGAS3HQEnrZSDWHlVcHnA7pa437SJBGhHdIQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=qpOdUqte7x1U5dEfzNR7kru+hZBpbRHgsWsI8hebga6piqKKp21MTE9wBRa3Srv60CZ7086eOW5iiycjEfKbVdrXdy3ZVBWnLVAhZGXqmP+6mkpti5hQSrlspnZeppPeAiDLFXZnwjxJdunU8tOQyyLg66ZQKdnKe/YsdCtwRUBMkfOxd5tq3QlxYDt+ZA248AbWWlUz3XqCOQ309zJu49AtU34HlhJHamy9HXDw7jzWFbS6r/l6W0BOHp1PTOwbcpz4oAj24kV7zk4VRWi/+ce0JSJlAoI2Qb1LRp4YTVPkB/3iSY07T7UnV3Mw1Z7/vFqZZk9tgzPMbBGmuLCr/w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uBoMZHCGSN3VrZV26LTJ8jkuFBmSk/ITkUyZv1ZBc3waVpxLpERsAAwTAZaw7TDsqciUHIMAOfy+y45zQ0Vku0Bmtu9vshoBDqVIiIitdQY/fLq5tDiXmsHWpB8mREWgGrWyw+ZuYlwQ8ZLK+gyc2X6wKlmdEQUFJJjAe15hBuDmeKsXqaIE7p96AQao+mJEoPyrQuG2YagfXpi8VFzW8n8BahywDSrJVygVE/B34at30iJ84ctrYtc8YaDUDBcZzb5N/wa/zXYrkrMVPuZX3ovjAGJCEG6fNeQL1gza/GxaUWEy0SyXemlfqdXFpdGt0fl+w5Qnl0ztnLGH5MaVfw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 17 Mar 2025 09:29:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHblqk6YtpfolyfmEyO326feCx3mrN3A2MAgAANRIA=
  • Thread-topic: [PATCH v2 6/7] xen: introduce Kconfig HAS_PAGING_MEMPOOL

Hi Jan,

> On 17 Mar 2025, at 08:41, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 16.03.2025 20:24, Luca Fancellu wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -74,6 +74,9 @@ config HAS_KEXEC
>> config HAS_LLC_COLORING
>> bool
>> 
>> +config HAS_PAGING_MEMPOOL
>> + bool
> 
> Imo this is too little of a change outside of Arm-specific code here. Just
> go grep for "paging_mempool" to see what pretty obviously wants to fall
> under that new control. There may be more stuff. The stubs for
> arch_{get,set}_paging_mempool_size() likely also want to live in a header,
> perhaps even one in asm-generic/.

I’m wondering, since we already have arch_{get,set}_paging_mempool_size
architecture specific, I believe this config needs to be ARCH_PAGING_MEMPOOL
and needs to provide stubs inside include/xen/domain.h in a similar way of how
ARCH_MAP_DOMAIN_PAGE is done.

What do you think?

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.