[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 00/17] make system memory API available for common code
- To: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- Date: Mon, 17 Mar 2025 10:21:00 +0100
- Cc: qemu-devel@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, alex.bennee@xxxxxxxxxx, Harsh Prateek Bora <harshpb@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, manos.pitsidianakis@xxxxxxxxxx, Palmer Dabbelt <palmer@xxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>
- Delivery-date: Mon, 17 Mar 2025 09:21:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 14/3/25 19:39, Pierrick Bouvier wrote:
On 3/14/25 11:34, Anthony PERARD wrote:
On Fri, Mar 14, 2025 at 10:33:08AM -0700, Pierrick Bouvier wrote:
Hi,
one patch is missing review:
[PATCH v5 12/17] hw/xen: add stubs for various functions.
My "Acked-by" wasn't enough? Feel free try change it to "Reviewed-by"
instead.
Those are differents. From what I understand, Reviewed implies Acked,
but the opposite is not true. If it was, they would be equivalent.
Thanks.
IIUC on QEMU Acked-by means "as a maintainer of files modified by
this patch, I don't have objection on my area, as long as someone
else takes the patch". It doesn't mean the patch has been reviewed.
Please correct me if I'm wrong.
Thanks,
Phil.
|