[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] libxl: avoid infinite loop in libxl__remove_directory()
On Thu, Mar 06, 2025 at 04:01:53PM +0100, Jürgen Groß wrote: > On 06.03.25 12:25, Jan Beulich wrote: > > Infinitely retrying the rmdir() invocation makes little sense. While the > > original observation was the log filling the disk (due to repeated > > "Directory not empty" errors, in turn occurring for unclear reasons), > > the loop wants breaking even if there was no error message being logged > > (much like is done in the similar loops in libxl__remove_file() and > > libxl__remove_file_or_directory()). > > > > Fixes: c4dcbee67e6d ("libxl: provide libxl__remove_file et al") > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > While probably a more sane solution by reworking this whole mess libxl? > is possible, this patch should solve the issue Jan has described. > > So: > > Reviewed-by: Juergen Gross <jgross@xxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |