Re: [PATCH v3] docs: specify numerical values of Xenstore commands

["Anthony PERARD" <anthony.perard@xxxxxxxxxx>]

On Wed, Mar 12, 2025 at 09:41:43AM +0100, Juergen Gross wrote:
> diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt
> index 7e1f031520..72db73deef 100644
> --- a/docs/misc/xenstore.txt
> +++ b/docs/misc/xenstore.txt
> @@ -86,6 +86,67 @@ parts of xenstore inaccessible to some clients.  In any 
> case passing
> +XS_CONTROL               0    optional
> +    If not supported, xenstore-control command will not work.
> +    XS_DEBUG is a deprecated alias of XS_CONTROL.
> +XS_DIRECTORY             1
> +XS_READ                  2
> +XS_GET_PERMS             3

This new table prefix message type names with "XS_", but the rest of the
document describe each type without the prefix. Isn't it going to be
confusing, and make it slightly harder to link this table to rest of the
document? (I often search by full word, like '\<GET_PERMS\>', because
that one key stroke in vim '*', so having different prefix makes it
harder to search)

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech