[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 2/2] tools/libxl: Skip missing PCI GSIs


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 7 Mar 2025 19:17:11 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYdp2KXh51I7oF/KfEovWNzNxs0Oiy1xi9uDyok5KHo=; b=AJDDG0W8kwt12d+BUQGOxnw3cerA0AyW/+BNyJ4qIbhTINeCBNC8RJstn5JXFdrT2RBxWAqUr6KjJrnd6aIVVm2GBT8WIMSl+GtMtj0DgcHme3ZQ8VVBblf0SHpKFyH0szxpgOLs7uhFTqvp7ae/cz+pJZsagnypj3CTXRNJi2/9KEhlhZbxl9wPUY/Ua4IiAIi6t2QfZDECwVMNkVP+74tmxXgfpe7WB2mBtq1AMp4Vz/PmRDTiM4yQG6j7Hx5KlQj957akfM0GLkDn1bp3y/MBKwIKM+0Q/5/f5XDxTStQMNVmN107kXoRBijGr+L5n3U4FryjAXNk5Qt8ZXOM3A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eQt612TIsesfj61qVT3feg4EtqBv3xS6ptkUtg2MyImjbFuMXM8Jt0Bzgewp8Uf4hzjjUMuGXtI2f8E8J5/NCD5f0exssQWDtV+d4yJ5EJaUGw4ztrupoEO2z/4By2Sm5rK2JKvs9yPSXuabpJ4v+wn8uHfkapwIK6+MYUma6ib/B7vv7JSs/1BOUJ8a+m2P/WnDDkvmCD9nWYCTElokmkWuoHQTwbQSdI5KVGsEJXGlAWf+NCITU8hUikyUsVjbsZXDSvHrnv+BvVH3swk8N0NxzNdDXXSNfeumeDZkQO5AJJCuRYYcLBkJKGoq4MEvBHsLJVje/+13nOyZrpau7w==
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>
  • Delivery-date: Sat, 08 Mar 2025 00:16:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

A PCI device may not have a legacy IRQ.  In that case, we don't need to
do anything, so don't fail in libxl__arch_hvm_map_gsi() and
libxl__arch_hvm_unmap_gsi().

Requires an updated pciback to return -ENOENT.

Fixes: f97f885c7198 ("tools: Add new function to do PIRQ (un)map on PVH dom0")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
v2:
Use gsi < 0 - Jan
---
 tools/libs/light/libxl_x86.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index a3164a3077..0a7f64ad46 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -901,7 +901,10 @@ int libxl__arch_hvm_map_gsi(libxl__gc *gc, uint32_t sbdf, 
uint32_t domid)
     int pirq = -1, gsi, r;
 
     gsi = xc_pcidev_get_gsi(CTX->xch, sbdf);
-    if (gsi < 0) {
+    if (gsi < 0 && errno == ENOENT) {
+        LOGD(DEBUG, domid, "xc_pcidev_get_gsi no gsi");
+        return 0;
+    } else if (gsi < 0) {
         return ERROR_FAIL;
     }
 
@@ -925,7 +928,10 @@ int libxl__arch_hvm_unmap_gsi(libxl__gc *gc, uint32_t 
sbdf, uint32_t domid)
     int pirq = -1, gsi, r;
 
     gsi = xc_pcidev_get_gsi(CTX->xch, sbdf);
-    if (gsi < 0) {
+    if (gsi < 0 && errno == ENOENT) {
+        LOGD(DEBUG, domid, "xc_pcidev_get_gsi no gsi");
+        return 0;
+    } else if (gsi < 0) {
         return ERROR_FAIL;
     }
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.