[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/2] tools/ctrl: Silence missing GSI in xc_pcidev_get_gsi()
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 7 Mar 2025 19:17:10 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaI6EZemoHm5B0weo/dwTRxCldsMAovM/DZArusHS5o=; b=l5ljIHZy5JUoLBO2iWUpeyHRN096+2kMNFHsVvzdxJWSN4yoKmblrzRr4c7dET0IJCWJ8UkRZNkyD7nQptz/xSjHuM0lW3/0lGE/CJrWnu944zos+jAiv7nLQkjOkE9Jk6zr7sB+Dvd5p7IKE/vUPvxNcDmqDDdLUKpgd0GUOmapbrAiTWgMvZKWdK6AOzEBcJvAbOjZHFjmftq/oz+su5vE6QGgQaMuW4ilkcjZiIQpraz3vFTnQRFha7ElBO+Xx8n2Bo9acBrnRyf+LQlibjd5Fa4V++qdMawWvEec/FkZNjjsCvz57JVa3gz6f5q6ILhyb204aFq91IPxMQOJxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dOyZzMtiqHyTAAI3GFFrJpDwcasBslHC0E3WemiSzDtxNmlqwgy0vaNowC5uQwphNpy7iTntYajsO3bBp+CtpD5kAu8vOU0mGYIcr4dA64fyKkyEBGGLQ8L+196xoOs9zd6LT4l4q6YVynv6SdGeR9aJ6r4TWwKW6vefIY5ov/+ywx2Rv4wef6JGxExi+YEBQA3qD5XeO/5VTeyEK9FUf5LLQnnC0xdUQln39JvxIctKbU4qIlYFdFgG4kxZJ1KRTcTXdUSYGzynGxQQbj5tWf6trvy56tpy9KOk339gcArJNETCQaV5qQqfBwv+GJ1fewUAbEHEIdR7dSVhEvv7Ww==
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>
- Delivery-date: Sat, 08 Mar 2025 00:16:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
It is valid for a PCI device to not have a legacy IRQ. In that case, do
not print an error to keep the lgs clean.
This relies on pciback being updated to return -ENOENT for a missing
GSI.
Fixes: b93e5981d258 ("tools: Add new function to get gsi from dev")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
v2:
Use Xen code style
Print sbdf
---
tools/libs/ctrl/xc_linux.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/libs/ctrl/xc_linux.c b/tools/libs/ctrl/xc_linux.c
index 92591e49a1..2b2d7b3196 100644
--- a/tools/libs/ctrl/xc_linux.c
+++ b/tools/libs/ctrl/xc_linux.c
@@ -77,9 +77,14 @@ int xc_pcidev_get_gsi(xc_interface *xch, uint32_t sbdf)
ret = ioctl(xencall_fd(xch->xcall),
IOCTL_PRIVCMD_PCIDEV_GET_GSI, &dev_gsi);
- if (ret < 0) {
- PERROR("Failed to get gsi from dev");
- } else {
+ if ( ret < 0 )
+ {
+ if ( errno != ENOENT )
+ PERROR("Failed to get gsi for dev %04x:%02x:%02x.%u",
+ sbdf >> 16, (sbdf >> 8) & 0xff, sbdf >> 3 & 0x1f, sbdf & 0x7);
+ }
+ else
+ {
ret = dev_gsi.gsi;
}
--
2.34.1
|
