[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/23] xen/arm: dom0less delay xenstore initialization
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 7 Mar 2025 13:36:15 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0q+rxR/oDa6kXpXFSCptbEN9+6EcP1t4CN77c4LBSA=; b=qoAzDsrpzIBq3DQIJFUMGvuCboIBoqrCQz9QAw5zgbkrKDF5+AFqwfw3kAAwbn4MBgKjCH+90SeTcUiEEi7Yk7Kqo3LIDIs08Os5eRy+CQ1hUHolAmEOnkiSzdj9nfodvTH0K+FSURFDF5iIyGkj8eq0hUF95URCvOkPmPzs8/lNuh9BLveuveyhSTaAAGenvQX4UfeVmJQxom9q8dBAuR29lge9TVhLjNdIk0C2b+JtJV30hB9MxaLAPi2wz9XXXY2gXELKbZLaR//CDzVZwmdhDYxTiL0EA+dOI2cnVDEsHhPM/GOHP+TsTwd0+/5GPoo+TNVPDyiMjHKq7HMA5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=is8uSy0zNvmyO//9lEL/xeCb4uMK/2Q7qJZMoVXcSohLYc0JvvSPVecDAMojZeQzHD16Dpe2Nf9LKBXeOLZe9L2mK38eq1pi9dg5dh+RjyZaCI9GTeOr7+TzPtx9lbbK/ZpvCyqx5QTqCMshEv/DqYgCw9cLwlc/fXDGKjxdo8xrFUy5g2f8LA/c6JqGX6Ruvb3JjpZDHaHXjG82GHU5UrzeoaEcyYXwtFYLPoYhCI0znEOfzKBtxls09acPPD0mj7OOcf1tEiltH04qCbKxv/1dszeaCUXqBVrp9VycvU3sH4U79kOACkVVXsxXOKv9I96BN6Ypp94undUeAR1pbw==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 07 Mar 2025 18:36:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-03-06 20:59, Stefano Stabellini wrote:
On Thu, 6 Mar 2025, Jason Andryuk wrote:
@@ -697,7 +703,7 @@ static int __init alloc_xenstore_evtchn(struct domain *d)
int rc;
alloc.dom = d->domain_id;
- alloc.remote_dom = hardware_domain->domain_id;
+ alloc.remote_dom = xs_domid;
This...
rc = evtchn_alloc_unbound(&alloc, 0);
if ( rc )
{
@@ -767,16 +769,10 @@ static int __init alloc_xenstore_params(struct
kernel_info *kinfo)
struct domain *d = kinfo->d;
int rc = 0;
- if ( kinfo->dom0less_feature & (DOM0LESS_XENSTORE | DOM0LESS_XS_LEGACY) )
- {
- ASSERT(hardware_domain);
- rc = alloc_xenstore_evtchn(d);
This patch looks correct. However, I don't understand why you didn't
keep the call to alloc_xenstore_evtchn in alloc_xenstore_params.
alloc_xenstore_evtchn() needs to be delayed so that xs_domid is available.
Regards,
Jason
|