[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] tools/ctrl: Silence missing GSI in xc_pcidev_get_gsi()


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Wed, 26 Feb 2025 15:10:21 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1PQd4NLZQqhDaO6y0X845NeNwbBnbu7oaTg1UI0OYg=; b=XZD04JznFOx4a+TctkmpwlsC8q9BxZkcbLhUl3/rJnCKqLUbHIgz7sYIKqzfRK4OAipPCakknHbrPd6xnR6djNlASar0QN6n5nQOHROsEv9tAvROWYgi8QM+dUDDd+QUlKiwaAe8LokgKkBydNNG4n3Af8Y8e8vS/dp+t/luyd893lsUVRXX9G6IMLDDL+KPCPjGrdRyRqasq1Zhv7CNaTu3fu5ELIKv/gWwV6JY/Um4XxXrikHVbteQJfSyv2ImdvPLnEKZxEB13GfPHfHPrDslTVy149lc1b0VIIceguaCp/pRXkCJhPRTcyRiFxF/qCpy1onCddTDj67Jc8kg+w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=joteRQjOz7O7UqJUO4YBzIQWz5+HRdjwoncGr9gCkuPyZd1s41SLEtN8IPMe2M7nU3I8YpusAO38lCeh9PtL0hOjsxTD3N8Bs2/mXY9uBLdX4Sf2BQOgoXUT3CI3S7SnNicw8GfhZVmzUefmidazlYgqpsPFGiTunzqaQ8TsXxQgNhrgrpbJblFxAa1zPi2AkpwC9DErTxAK+DhEweuazjfpNVoV1YwGRDoUFZRpYlR566K15/bPCYGpb4WKSRq5qXEb/4aRMNd0/JrWV4cBbq6ZKnv1bPId/0Bgj6Zk0le/RsC4X1X01MLolVe+8Spv+eaAH1dThilTYqBvbyMTaw==
  • Cc: Jiqian Chen <Jiqian.Chen@xxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, "Jason Andryuk" <jason.andryuk@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Wed, 26 Feb 2025 20:09:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

It is valid for a PCI device to not have a legacy IRQ.  In that case, do
not print an error to keep the lgs clean.

This relies on pciback being updated to return -ENOENT for a missing
GSI.

Fixes: b93e5981d258 ("tools: Add new function to get gsi from dev")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 tools/libs/ctrl/xc_linux.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/libs/ctrl/xc_linux.c b/tools/libs/ctrl/xc_linux.c
index 92591e49a1..c18f09392f 100644
--- a/tools/libs/ctrl/xc_linux.c
+++ b/tools/libs/ctrl/xc_linux.c
@@ -78,7 +78,8 @@ int xc_pcidev_get_gsi(xc_interface *xch, uint32_t sbdf)
                 IOCTL_PRIVCMD_PCIDEV_GET_GSI, &dev_gsi);
 
     if (ret < 0) {
-        PERROR("Failed to get gsi from dev");
+        if (errno != ENOENT)
+            PERROR("Failed to get gsi from dev");
     } else {
         ret = dev_gsi.gsi;
     }
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.