[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] tools/libxl: Skip missing PCI GSIs


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Wed, 26 Feb 2025 15:10:22 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXif3xxHR0swgkqMsjQ8Zq4Y3dDR8D/QU5nuLdzLagc=; b=zHxot52XJCtGxDiKTI2AWwaC+zKaBXtEPnddzzN4Zib1b1W7d8YJor8F7mNBYKPEX7Jg0Hgb9p1ZOxn2Sx5XxwdeVx2ZTCou4HmHF/47H40sp0y8OJ8eI1EBX6fDCm9MmXNYfFpgeY7boxHpa9QhZHxvcA5hWT0Nc6Tjabr+rzJTZHMza+DP2uvxfdXAB8D06BzDY9AE1SOxNvwU1t+f0SRgEi80mWmi7oLAnC0xNBuKi8u8jHdK3JRG/mrb9gkKuq24QTFpN9QLgW3L+XFUc815kupnw/SrD68QjiD21EH5wdZfrm8FbH+42QbCBxk2tAWLJqdF2xvhEERgTmhIPw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JhTZhbicqKVlpAnCtG4zRW21VNGtdMc7u696q/oNmzQNg3Q1Y1CB3SPcW5/6tN0zsg15Tv79Gmp7zI+sUJZGGrqrsiGEGWiUTstLy6FAfkR5szCaXtvwTyH01z5sf5MAjwEZtyfAtezspAABVfs3uxtwbS91kDqLZ9Ixl+pzIgNwXSqylSYTbaNsSGHvhqiJx+xEthdCEPtDlbr3Hekfg12YZi1HK3AzBwlukn6biqKnhsNXAHRCCTUQjDis7Aj8kOol9wap1SVz1aHWJJwnxHJUKSWvzASFtxf4EFTvMJ0XduPGRdOO/1YNXlq7MHUlRKH9AsYoZOzp5Hqhe2pfkg==
  • Cc: Jiqian Chen <Jiqian.Chen@xxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, "Jason Andryuk" <jason.andryuk@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Wed, 26 Feb 2025 20:09:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

A PCI device may not have a legacy IRQ.  In that case, we don't need to
do anything, so don't fail in libxl__arch_hvm_map_gsi() and
libxl__arch_hvm_unmap_gsi().

Requires an updated pciback to return -ENOENT.

Fixes: f97f885c7198 ("tools: Add new function to do PIRQ (un)map on PVH dom0")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 tools/libs/light/libxl_x86.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index a3164a3077..63208362af 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -901,7 +901,10 @@ int libxl__arch_hvm_map_gsi(libxl__gc *gc, uint32_t sbdf, 
uint32_t domid)
     int pirq = -1, gsi, r;
 
     gsi = xc_pcidev_get_gsi(CTX->xch, sbdf);
-    if (gsi < 0) {
+    if (gsi == -1 && errno == ENOENT) {
+        LOGD(DEBUG, domid, "xc_pcidev_get_gsi no gsi");
+        return 0;
+    } else if (gsi < 0) {
         return ERROR_FAIL;
     }
 
@@ -925,7 +928,10 @@ int libxl__arch_hvm_unmap_gsi(libxl__gc *gc, uint32_t 
sbdf, uint32_t domid)
     int pirq = -1, gsi, r;
 
     gsi = xc_pcidev_get_gsi(CTX->xch, sbdf);
-    if (gsi < 0) {
+    if (gsi == -1 && errno == ENOENT) {
+        LOGD(DEBUG, domid, "xc_pcidev_get_gsi no gsi");
+        return 0;
+    } else if (gsi < 0) {
         return ERROR_FAIL;
     }
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.