[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/24] arm/vuart: move vpl011-related code to vpl011 emulator
- To: Jan Beulich <jbeulich@xxxxxxxx>, <dmukhin@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 22 Jan 2025 16:09:55 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZebZP97Gkv980sGkf0i4UIqMoPKku5TR0lgvSI1jARs=; b=Q2bW/1OVpmwv5SlGO8/A37KlyWHjaJVLqULBhWAz1XvlVpzJsuejk/6AeuEt5QW6ez9lsIPNM/CN/gA/+byPz0VzAGWjaVuZkRDqkyfC+lOwSl/LYw+RrXlzPumr473ag+RKUTSVdhUhC6lOqI/I6OX6ceodqlEyQrnjWLvYAxhZ876homtNViIfkHEk5nCjhFmDcQiOYdjoeTT1+CCaugUa2+JOD+3775hSVpqt1UeaqXLtGABzhx/aEguH8+2TmeuD+7AN2ZmBkYrixFDdJCHc32uARFp9ZJ2n/JCL9H7proZea9/AFZgPXeR3pduyhvwltgqErdIcI/EIBqN5AQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IOjemcsZOnKu25m1QgoCG9vH2Tt8NTplmXjZDjxGQVOGSS5YzXxra7y+Nb7KgEQ2IDQMrG0r01yBuQIjwN8AvvkMSPzaQT3ky81uOsyc1/9QG9rZguX2i79FOd/2ji2spTsCRKlPazDVUJL04jhfniVqtYH38ZnMaFXIMASHBT6uLKRPmqoGvU0GBrfijFN06QIvz72OY2rO8ggET0SsC2hDfgfpk7cMkd+u7w8a/9m2arL1dBxIiK+C0QIhT2T8NLXEQt6KOty7alH4OyYwAnNn2lIT0pv7piuGpirqliwTfdagJyVabLnpFmP8PNxp+sFhq8A8HF/E0tRLLD4yFA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Jan 2025 21:10:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-01-22 02:26, Jan Beulich wrote:
On 21.01.2025 23:56, Jason Andryuk wrote:
On 2025-01-03 20:58, Denis Mukhin via B4 Relay wrote:
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -579,6 +571,9 @@ static void __serial_rx(char c)
if ( pv_shim && pv_console )
consoled_guest_tx(c);
#endif
+
+ if ( rc )
+ printk(KERN_ERR "d%pd: failed to process console input: %d\n", d, rc);
}
static void cf_check serial_rx(char c)
This will print the ENOSPC that was formerly silent. Since this is
input from the console, that seems more informative to the user and okay
to me.
I don't view this as okay. For one it needs to be a guest log level, such
that rate limiting can suitably suppress too many of these messages in a
short time (which in particular might happen if the ENOSPC reason isn't
dealt with by the receiving domain). And then I wonder whether this
wouldn't better be even more strongly limited, perhaps to just once per
domain.
I was thinking of a user typing into the console. Silently dropping
characters is frustrating when you don't know it is happening. On the
other hand, if the domU is echoing characters, then the user receives
feedback on their typing. So maybe silently ignoring ENOSPC is okay?
ENODEV could be okay just once. It could also be helpful to get the
message if you come back a week later and try to type into the same
console. But these the user should rate limit themselves when they just
keep getting errors :)
I'm also unconvinced of KERN_ERR - from Xen's perspective nothing error-
like has happened, once again most notably for the ENOSPC case. I'd view
this as a warning at best.
Finally: Why d%pd? It ought to be just %pd.
Yes, thanks.
Regards,
Jason
|
