[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/24] arm/vuart: move vpl011-related code to vpl011 emulator
- To: <dmukhin@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 21 Jan 2025 17:56:42 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ford.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MtwZNlSo1PT/CNoHxOp2k22F/4id72rjUEgzv0Q3XUM=; b=JXfc9+JaOIU28hNCOd/5mT8cksoc/KrIzb3UIfHWjYv12U499LIMO9zi5drXCCTASGllcLANvdAUKDCe/0wGt8nYpED7PdOPzB7sS2I7Mf3+ZZCuh7wVCyW/mpRnwm0PzwwRnLLusY3OBxYw2muTl1HrPZIIOIKnes7VGqC5qHTkkWScgnhTxM6YaTLTqe9QdIDbxhpwQJhFU0GUn18yu7blgFFOQf9z7VeeA4FvXX8DgTNHY9gOFVMhdkG4EIDpqSRQ2bUAEd+qbHuuXfItV9GbQuloh5VpKfj990gSjvsZkKQdyzrxIcrrDXKvD3AsdwxCw2IdlEho1l394ZpMbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w8SejpETBUgZzvhJBA4UfMP6ksRSEY2XzX8oSNMvp2lxQ9e+5M+xX9zWYUj725J7KoOD46FXPfM/H0nST5KmpcXteBCeAmfgjVEzO17YQooYwMbHnBEG3giQ6S6FJVHyo9nQ1ReA0no2TbcaM2IOUeuOEW122VK21Dk0HWQcfe2SPeeZnVQd3N8QamlawBSV7ODT7rolhqRyE+waqAhZI5yzlGmiGpeoxiRnTEUbAJQlRgjTIzzbx9uhMVINzQO3hFjAOWKoIoM26lat+zlEPuEY4NfMFeCo/0M4lYE4EIKRcysil5lnWPlV4mP8B8HaB0GmKZi1Z9ngomxusJgruA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 21 Jan 2025 23:54:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-01-03 20:58, Denis Mukhin via B4 Relay wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>
Xen console driver has vpl011-related logic which shall belong vpl011 emulator
code (Arm port). Move vpl011-related code from arch-independent console driver
to Arm's vpl011.c.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index
4cb397116b44935214801c496b30e44c9399c59a..1411c991977b5fb26ee5709e523b7bc32b612808
100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -579,6 +571,9 @@ static void __serial_rx(char c)
if ( pv_shim && pv_console )
consoled_guest_tx(c);
#endif
+
+ if ( rc )
+ printk(KERN_ERR "d%pd: failed to process console input: %d\n", d, rc);
}
static void cf_check serial_rx(char c)
This will print the ENOSPC that was formerly silent. Since this is
input from the console, that seems more informative to the user and okay
to me.
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
