[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 0/9] SMMU handling for PCIe Passthrough on ARM


  • To: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • Date: Mon, 13 Jan 2025 12:27:37 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oPF4uZoNZ80Bz21eZPEr3dPX2ojLe9SksvXBnu2Sr2E=; b=EBHCKZNbLE6dMNjcVla7w0MDMnKReXhHw73R/1inaPYflgGx5aj6lG4E5dbljMZ5n+X7eIaLMLGu2iMIycFahJUffogOR/9ylntSeAOWv+RB98DuYff/xuiSjgGLQ4MUcO+Ogv+4qicKHLfgRr19CZRmnE1TDSszJ1xIQIvEhFCWYWZfO5qo4+9XjK/7Vb9jEJ1SpD7Fs6TdqdQkh0dSj4YXoqvrBGlErT6oDizsM42um1MPeOQpNISOnnQo69FfR4h8JbB3u2fZ4SiGd/Dc4V/4jTwKlP1E/Cuc7KgUfNhnazpjTo98mBshhiObfJKuF++TcCP9v4fHRRyyq8BGvg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SqbBmEXJy1AVnqM40pq3eXJjLqEahAvsBksAS5S19eAyHlWrH/IHPmjNUzX6xryUfBw50QmRYDwxn+bo7tmVoi++4lunrNv8aMMLF1B2zxWeZjIGZC7ab4sOFvKg0GnZENZU6fjT8e7RA17awaA7VdEcOBBkYNGU37vIQRQ6sKXX61qIro96oYNmda0Z4NAJIQMsm691CcgND19GqhSfPNRH5j0KhQsU8dgRFYLvWpwoCesubgomkyAfH6o6da+E1YBBg/lqVrtE9Y5w9Hx2Uc2uAOqNyATLC2ngiZHUq/VKl/2X4R+M/8VOaNd3MvkVk3T41ggTH+2kY6XngtaP2g==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "George Dunlap" <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 13 Jan 2025 17:27:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 1/13/25 06:17, Mykyta Poturai wrote:
> On 09.11.23 20:27, Stewart Hildebrand wrote:
>> This series introduces SMMU handling for PCIe passthrough on ARM. These 
>> patches
>> should be able to be upstreamed independently from the vPCI series [1]. See 
>> [2]
>> for notes about test cases.
>>
>> [1] 
>> https://lists.xenproject.org/archives/html/xen-devel/2023-10/msg00660.html
>> [2] 
>> https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg01135.html
>>
>> v5->v6:
>> * don't revert ("xen/arm: Add cmdline boot option "pci-passthrough = 
>> <boolean>"")
>> * add ("xen/arm: enable dom0 to use PCI devices with pci-passthrough=no")
>>
>> v4->v5:
>> * drop ("xen/arm: Improve readability of check for registered devices")
>> * drop ("xen/arm: Move is_protected flag to struct device")
>> * add ("xen/arm: don't pass iommu properties to hwdom for iommu-map")
>> * add ("xen/arm: Fix mapping for PCI bridge mmio region")
>> * revert ("xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"")
>> * add ("xen/arm: Map ITS doorbell register to IOMMU page tables.")
>> * fix test case #1 with PCI device in dom0
>>
>> v3->v4:
>> * split a change from ("xen/arm: Move is_protected flag to struct device") 
>> into
>>    a new separate patch
>> * see individual patches for further details
>>
>> v2->v3:
>> * drop "pci/arm: Use iommu_add_dt_pci_device()"
>> * drop "RFC: pci/arm: don't do iommu call for phantom functions"
>> * move invocation of sideband ID mapping function to add_device()
>>    platform_ops/iommu_ops hook
>>
>> v1->v2:
>> * phantom device handling
>> * shuffle around iommu_add_dt_pci_device()
>>
>> Oleksandr Andrushchenko (1):
>>    xen/arm: smmuv2: Add PCI devices support for SMMUv2
>>
>> Oleksandr Tyshchenko (2):
>>    iommu/arm: Add iommu_dt_xlate()
>>    iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API
>>
>> Rahul Singh (3):
>>    xen/arm: smmuv3: Add PCI devices support for SMMUv3
>>    xen/arm: Fix mapping for PCI bridge mmio region
>>    xen/arm: Map ITS doorbell register to IOMMU page tables
>>
>> Stewart Hildebrand (3):
>>    xen/arm: don't pass iommu properties to hwdom for iommu-map
>>    iommu/arm: iommu_add_dt_pci_sideband_ids phantom handling
>>    xen/arm: enable dom0 to use PCI devices with pci-passthrough=no
>>
>>   xen/arch/arm/device.c                 |   2 +-
>>   xen/arch/arm/domain_build.c           |   2 +
>>   xen/arch/arm/pci/pci.c                |   3 +-
>>   xen/arch/arm/vgic-v3-its.c            |  15 ++
>>   xen/common/device_tree.c              |  91 ++++++++++++
>>   xen/drivers/passthrough/arm/smmu-v3.c | 131 +++++++++++++++--
>>   xen/drivers/passthrough/arm/smmu.c    | 199 ++++++++++++++++++++++----
>>   xen/drivers/passthrough/device_tree.c |  97 ++++++++++---
>>   xen/drivers/pci/physdev.c             |   6 -
>>   xen/include/xen/device_tree.h         |  23 +++
>>   xen/include/xen/iommu.h               |  26 +++-
>>   11 files changed, 528 insertions(+), 67 deletions(-)
>>
>>
>> base-commit: bede1c7e3b790b63f1ff3ea3ee4e476b012fdf2c
> 
> Hi Stewart,
> I noticed there was no activity for this series for some time. Are you 
> still working on this or would it be okay if I take this over and start 
> preparing the V7?
> 

Hi Mykyta,

Go ahead, please feel free to take it over. Your help is very much
appreciated. I made a couple of updates, but the feedback still needs to
be addressed. Please see my latest working branch here:
https://github.com/stewdk/xen/tree/pcie-passthrough-smmu-v7



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.