[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH for-4.20] public/version: soften wording for deprecated sub-ops
These interfaces were - afaict - originally introduced this way on the firm assumption that the used array sizes would be good virtually forever. While this assumption turned out to not be true for at least some of them, this still doesn't really render them "broken": They still fit their original purpose, and they are still usable for a fair subset of environments. Re-word the comments accordingly. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> --- Despite having looked at the series back when it was posted / discussed, I'm (now) somewhat puzzled that XENVER_compile_info didn't gain a non- truncating replacement sub-op. The commit's description doesn't say anything in this regard; it rather gives the impression that all sub-ops with limitations would gain unrestricted counterparts. --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -22,7 +22,8 @@ /* * arg == xen_extraversion_t. * - * This API/ABI is broken. Use XENVER_extraversion2 where possible. + * This API/ABI is deprecated, for its size limitation. Use + * XENVER_extraversion2 where possible. */ #define XENVER_extraversion 1 typedef char xen_extraversion_t[16]; @@ -31,7 +32,8 @@ typedef char xen_extraversion_t[16]; /* * arg == xen_compile_info_t. * - * This API/ABI is broken and truncates data. + * This API/ABI is deprecated, for its size limitations. It may in particular + * silently truncate data. */ #define XENVER_compile_info 2 struct xen_compile_info { @@ -45,7 +47,8 @@ typedef struct xen_compile_info xen_comp /* * arg == xen_capabilities_info_t. * - * This API/ABI is broken. Use XENVER_capabilities2 where possible. + * This API/ABI is deprecated, for its size limitation. Use + * XENVER_capabilities2 where possible. */ #define XENVER_capabilities 3 typedef char xen_capabilities_info_t[1024]; @@ -54,7 +57,8 @@ typedef char xen_capabilities_info_t[102 /* * arg == xen_changeset_info_t. * - * This API/ABI is broken. Use XENVER_changeset2 where possible. + * This API/ABI is deprecated, for its size limitation. Use + * XENVER_changeset2 where possible. */ #define XENVER_changeset 4 typedef char xen_changeset_info_t[64]; @@ -116,7 +120,8 @@ typedef struct xen_feature_info xen_feat /* * arg == xen_commandline_t. * - * This API/ABI is broken. Use XENVER_commandline2 where possible. + * This API/ABI is deprecated, for its size limitation. Use + * XENVER_commandline2 where possible. */ #define XENVER_commandline 9 typedef char xen_commandline_t[1024];
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |