Re: [PATCH v2 08/35] x86/domain: introduce domain_has_vuart()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Wednesday, December 11th, 2024 at 7:13 AM, Roger Pau Monné 
<roger.pau@xxxxxxxxxx> wrote:

>
>
> On Thu, Dec 05, 2024 at 08:41:38PM -0800, Denis Mukhin via B4 Relay wrote:
>
> > From: Denis Mukhin dmukhin@xxxxxxxx
> >
> > Introduce domain_has_vuart() for x86 port to be used in the console driver.
> >
> > Signed-off-by: Denis Mukhin dmukhin@xxxxxxxx
> > ---
> > xen/arch/x86/include/asm/domain.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/arch/x86/include/asm/domain.h 
> > b/xen/arch/x86/include/asm/domain.h
> > index 
> > b79d6badd71c4d96279555df62fad75fe817a2b6..c1d0d1f47324e8cc678a4c76c43f86820a89e7b3
> >  100644
> > --- a/xen/arch/x86/include/asm/domain.h
> > +++ b/xen/arch/x86/include/asm/domain.h
> > @@ -506,6 +506,9 @@ struct arch_domain
> > #define has_pirq(d) (!!((d)->arch.emulation_flags & X86_EMU_USE_PIRQ))
> > #define has_vpci(d) (!!((d)->arch.emulation_flags & X86_EMU_VPCI))
> >
> > +/* NB: same symbol as in Arm port */
> > +#define domain_has_vuart(d) false
>
>
> Don't you need to consume d in the macro, ie:
>
> #define domain_has_vuart(d) ((void)(d), false)

I reworked that code and merged per-arch domain_has_vuart() patches
into one arch-independent domain_has_vuart().

>
> Thanks, Roger.