Re: [PATCH 09/36] riscv/domain: introduce domain_has_vuart()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Friday, December 6th, 2024 at 1:32 PM, Denis Mukhin <dmkhn@xxxxxxxxx> wrote:

> 
> 
> 
> On Wednesday, November 27th, 2024 at 5:02 AM, oleksii.kurochko@xxxxxxxxx 
> oleksii.kurochko@xxxxxxxxx wrote:
> 
> > On Tue, 2024-11-26 at 15:21 -0800, Denis Mukhin via B4 Relay wrote:
> > 
> > > From: Denis Mukhin dmukhin@xxxxxxxx
> > > 
> > > Introduce domain_has_vuart() for RISC-V port to be used in the
> > > console driver.
> > > 
> > > Signed-off-by: Denis Mukhin dmukhin@xxxxxxxx
> > > ---
> > > xen/arch/riscv/include/asm/domain.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/xen/arch/riscv/include/asm/domain.h
> > > b/xen/arch/riscv/include/asm/domain.h
> > > index
> > > c3d965a559b6ce3661bf17166d0c51853ff295a2..efbc4f1ea2619a187fe30ede17d
> > > 96de01e599220 100644
> > > --- a/xen/arch/riscv/include/asm/domain.h
> > > +++ b/xen/arch/riscv/include/asm/domain.h
> > > @@ -10,6 +10,8 @@ struct hvm_domain
> > > uint64_t params[HVM_NR_PARAMS];
> > > };
> > > 
> > > +#define domain_has_vuart(d) false
> > > +
> > > struct arch_vcpu_io {
> > > };
> > 
> > LGTM: Reviewed-by: Oleksii Kurochko oleksii.kurochko@xxxxxxxxx
> 
> 
> Thanks!
> 
> > Probably it would be nice instead of having stub ( #define
> > domain_has_vuart(d) false ) in arch specific code, just ifdef-ing it
> > and put somewhere in
> > <xen/domain.h> to not introduce this definition for each architecture
> > 
> > which doesn't support vuart now.
> 
> 
> Actually, my thought was adding arch-independent vuart layer which can
> call into vpl011, duart or ns8250.
> This way, domain_has_vuart() will move there, along w/ APIs which
> hooked into Xen console driver (e.g. ns8250's vuart_putchar()) will be
> all there as well.
> I kept this stub as is for now (in the follow on v2).

I ended up w/ domain_has_vuart() defined in xen/domain.h in v3:
   
https://lore.kernel.org/xen-devel/20250103-vuart-ns8250-v3-v1-6-c5d36b31d66c@xxxxxxxx/

> 
> > Thanks.
> > 
> > ~ Oleksii