[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Initialise memory type for struct kernel_info
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 23 Dec 2024 10:52:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0hNmcfkxhNf9uJvhPoMncXyvLT95JISaNVPdYxZKWs=; b=Kr8+cAGP85jT5EEWNh6S2kaqy2tVyNoIZghvtRGzAvcFbAsRWqVgDeW5QBr3KeCom5FZstI8yygUWEyrpPFT42wGwCBbvY2kD9W2lpzh9sbOeXxsv9c2tKg103w9xRiuIQSicvHEJIINU1Gi9NWAexDZJgj9viEyn9Wkymp58BOr4YOUxUu5F7dDdq/iQYqUoGUSQXUBo1SmG0xO3MwhJdlZd9E/xqcQ1e5qwgUqZjQ3iUW9xbf1o0qkUUEBou/2ZumPVfvh/TJLS7yjXaCPoeUDDiqYE7W853VsLVVj+5TdVm7qssrRX6gwaHYCOkdJBWj6QH5INJlxygOxA8L0fg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0hNmcfkxhNf9uJvhPoMncXyvLT95JISaNVPdYxZKWs=; b=EtP6KsFuEvtkI1puWiQcJLqwX06uK8GHqNe0Ah04Ln9KdilfCdMbSbsmNrF/b0gGJJCYBDlAiQlngYbBQbqBLes/2GC8eRDKbg3Bez+BAF8xQOBK64AxvQi9k9uOZb65CgoK7/gc3F0fN76aGMGu8JLla4aq9k2883wT+PeUzwbzaAivVhzEFFCKMHn/vCXL0ImBqfDYVvCEQ9rSo0lkomDq5TdT7elMud92JcSP8KO0u4kAwahytBblc0Wr+iln/lGIgCZ/VRXeOkOj+7C8iAVvG1AerPdl/SkZudIJySBelUB9FRYDs/V5OFwir3r3gN2ZvKTl1s5TLcWvkp+Dyg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=vjS1o7mfTY+dHnvAT42PgLlPVutZ9t2p6tVDjJMaEqJ0QOfBZtNANU3zp230DrOlwofAogyu2yfDGGRm5IX5hXk3igL/H3n+xYAlOY43YpMeDpGnrwTae1PgEUV8oATzaQ2qVC8rFxuHq9x6QVNGwnHNeyHvkO+PwMRsNeKkoynxNZIo61AnZwZyZatZWmtLjFfLRWWQf4dSBsJCIIe8lVEXI+/2PzlLBtxMTupBQJDRuM9hVSfyqJk4kaIxr4BvdLa1L71rG8TX57RX7P4IFA4xGUtgnPVAcqWYeJr+z1PRsNU0Em4d9zbkN0yTbBuEt9vOJ6Zf8nf2gHjX3DeDdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ROWD37ZqyGjWEeu7uvCP2qZUHgw7AM1GokUo8xhD1Bk1AJFIVgp91dfX8c9K0vRPD3T0y0u5LyNzsShKxM71q/ZVzY7gZFp08EvhaZ9i4DSRasELOScOOAJkcGZzR3CfAGEqTEOQpPTiOCnrG5i5gwThmRuqc2xFljZs9YymeBEqVX2ucO1fzko2X36Nu//w6YUe+Z27u7GEwTvMPPlbTk4icQja8Rix/LGrlggNGa+ptCEEwsi8WOycHpuz4yi0HAuhgsxo1+dAms8vcBBl8kppphHTdJwVQZ1jmEkPy32JMzbRk3LGrV5VazFNrSLcY+9g9zlmRAozwF9MO1xEUg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 23 Dec 2024 10:52:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbUvKnqvQwslwrpk6TiacMD2XmQ7LzewMAgAAj2ICAAAoCAIAAANWAgAABwIA=
- Thread-topic: [PATCH] xen/arm: Initialise memory type for struct kernel_info
Hi Julien and Michal,
> On 23 Dec 2024, at 10:45, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi,
>
> On 23/12/2024 10:42, Michal Orzel wrote:
>> On 23/12/2024 11:06, Julien Grall wrote:
>>>
>>>
>>> Hi Michal,
>>>
>>> On 23/12/2024 07:58, Michal Orzel wrote:
>>>>
>>>>
>>>> On 20/12/2024 16:19, Luca Fancellu wrote:
>>>>>
>>>>>
>>>>> Commit a14593e3995a ("xen/device-tree: Allow region overlapping with
>>>>> /memreserve/ ranges") introduced a type in the 'struct membanks_hdr'
>>>>> but forgot to update the 'struct kernel_info' initialiser, while
>>>>> it doesn't lead to failures because the field is not currently
>>>>> used while managing kernel_info structures, it's good to have it
>>>>> for completeness.
>>>> The last part "good to have it" does not sound like we need a Fixes tag.
>>>
>>> Reading the discussion, it sounds like ".type" is not always set and
>>> this is not properly documented. This means that in the future we may
>>> write a patch that requires to use ".type" and needs backported.
>>>
>>> But this would depend on this patch which was not tagged appropriately.
>>> Therefore, I would argue it needs a fixes tag (even though this is a
>>> latent bug) or at least a backport request.
>> Setting explicitly a type for structures not requiring it, does not seem
>> beneficial for me.
>
> I have to disagree. If we set type everywhere, then the developer doesn't
> need to think whether ".type" is garbagge or not.
So, my thought was to at least initialise it on the structures that goes around
in the codebase,
gnttab in find_host_extended_regions and shm_heap_banks in static-shmem.c usage
are less
spreaded.
However I have no objection to always initialise them all, so that anyone
sending patches that
use them, don’t need to think if the field is initialised or not.
I’m currently on leave, is it ok to wait until new year if any change is
required?
Cheers,
Luca
|
