[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Initialise memory type for struct kernel_info
- To: Julien Grall <julien@xxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 23 Dec 2024 11:42:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FWkkmoCtOLjgPmIhIObeh7B6vcx3nKSdD+4LedPLgPo=; b=h7EgBnuxzxTaLQeC9lKUp08VaAXQ0qcbIIb+CYb05ghRXoFPhms/2VfjXotru6A0IUN4kyiaI8R/DlJv8XlnWmvzg1qQXI1VO+Qrup+e/LPhXHN+qpay4+fGLr8GuzpHhxMAnKYYwbhAGUQdXafY/UFE7U3Z7vlNgXxlRb8fli7aGW4qzMy8X2UZfnoWwt//q2PrVXJco0P/f7Q1kgl237czmnub1Wt1xQB4dH86/xid5m3EzSXVZonAtsPsKolqTs6Tyb8GDNjDQRyfNRMaASsKHnohAI2FWCCkiJ7Dwwt25NMegndFxm+oKHdsA4J5tRaQbiJ4pYODuSVWsbsw5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IW9a9yk8V3GWkD7OQHYH9QUol9Ea5R3zHaYPMXvbqQ0rP/5z4MSkQztGsGm+rdjw+n9Ez95FX2CMPvXibdo8B2hwRg6Awn3jegbgXIQ4ycZ56j4phYjGhRCm0SCubxFbjQq+2TZPYnk+lXuP9Vc5UAn43v97K4LXO9orwKU3KSPbVQVcsQTL8Or8ixCy8pD6SFkugv9dX+EyhlJhPYVpSi2g0T5eBpqYDkHjcHuiPanG4QTxmUGkXps3Oe9THokomCerpsLZQOAnuRa5cyzLbw84PXIvExYMvAhGaOhsjbGAeJudItS58NMd3hyWebvSpF8JWwYjsqQyNKIgl0b8CQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 23 Dec 2024 10:43:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/12/2024 11:06, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 23/12/2024 07:58, Michal Orzel wrote:
>>
>>
>> On 20/12/2024 16:19, Luca Fancellu wrote:
>>>
>>>
>>> Commit a14593e3995a ("xen/device-tree: Allow region overlapping with
>>> /memreserve/ ranges") introduced a type in the 'struct membanks_hdr'
>>> but forgot to update the 'struct kernel_info' initialiser, while
>>> it doesn't lead to failures because the field is not currently
>>> used while managing kernel_info structures, it's good to have it
>>> for completeness.
>> The last part "good to have it" does not sound like we need a Fixes tag.
>
> Reading the discussion, it sounds like ".type" is not always set and
> this is not properly documented. This means that in the future we may
> write a patch that requires to use ".type" and needs backported.
>
> But this would depend on this patch which was not tagged appropriately.
> Therefore, I would argue it needs a fixes tag (even though this is a
> latent bug) or at least a backport request.
Ok, sounds good. But first, let's settle on what we actually want to do here,
if at all.
I would be ok with just documenting that .type field is for now only used with
bootinfo
related structures (after all, today it's used only in one bootfdt function).
Setting
explicitly a type for structures not requiring it, does not seem beneficial for
me.
~Michal
|
