Re: [PATCH] x86/ucode: Only rescan features on successful microcode load

[Jan Beulich <jbeulich@xxxxxxxx>]

On 19.11.2024 22:58, Andrew Cooper wrote:
> There's no point rescanning if we didn't load something new.  Take the
> opportunity to make the comment a bit more concise.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> @@ -911,14 +915,5 @@ int __init early_microcode_init(struct boot_info *bi)
>  
>      rc = early_microcode_load(bi);
>  
> -    /*
> -     * Some CPUID leaves and MSRs are only present after microcode updates
> -     * on some processors. We take the chance here to make sure what little
> -     * state we have already probed is re-probed in order to ensure we do
> -     * not use stale values. tsx_init() in particular needs to have up to
> -     * date MSR_ARCH_CAPS.
> -     */
> -    early_cpu_init(false);
> -
>      return rc;
>  }

In principle with this rc could be dropped from the function. It's then further
unclear why early_microcode_load() needs to be a separate function, rather than
simply being inlined here (as I expect the compiler is going to do anyway). But
yes, one thing at a time ...

Jan