[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] arm/setup: Move MMU specific extern declarations to mmu/mm.h
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 18 Nov 2024 09:26:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AjfDe4ftPxQF8j1BRyobcwMfo20svTID/ViM8jf14FQ=; b=QzaG3IGrAHBUbdg4lT41ZsGngbjLWmiA/JCqi4tf0Cb1amNhvpoE7ZhH7QyOOKPG1OG7Bhi6Zn5euJecGVhJ5Ycr0hqzIOoW4ptSnEhM7Up91rg4O7e2m30uEx2rpU7np48UZrMLMMz73rwuoTDgDNQWY8fReBMbIfz64C6seH+54dImMPXe+Lcr46dpsjYghQTCUIoPL9yHktadWOFSbnjjLSexnajLLhPdzlst35utAW6aGK5CQ0+Wt6QaDeot6M2morDIMu0X4kZT3sYLp50c7mS9K0o8NeYopCSjrcFVrjD9o4MzZ5u5FNLa3U6JvLjTFj+JcRsN5YYOz1lgPA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AjfDe4ftPxQF8j1BRyobcwMfo20svTID/ViM8jf14FQ=; b=YhE9BjaNSx/cafvv2PlHKwcOkXxQ52K6aA0Z70ls+MdeGgLkWrn2v/FxmFVzkEdDxQUDRIn4nANtx0iiyGanoTRNzabfHL0LqmocVDbUk7Kx8/ySpDLVLtJTQSjnNELoxYqK1+vyQ3esDieGuZFp6mKey0GbDtYmNozh3imiVArc9wukHTxczHi/dh26TZN2oel8XUzZY207Mum+7kPdz190uexKBkzK00dNWQnCGOq/kXCXtd49CMawLtRMOQ/tjxhFvnJVJQHGiiOVwCnc1tBEXfqJjT2wa200CI/AnokElHSiWiTntvg+ZLCkI7oc53lZrkphwDU1wpNiDsRNBQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=aZVx85zyRKSjUPQlb8AVwpN7Qd276yzIqmaiPMHAPwQxNJHZTEgM89aQ7wN6xCNyukm+x8/+H1q+TKR7onOSSGwQkar1NFD/BE0YgrHh+gHqmAsn2BoIaj16klJcpLbS0fimGYYeShfLcLNr3KNtOkI65w9nZiOW8DJpudhNM5quRl39HLZtVKW2IKvD6a7MBYi7DXefgjEZWJrg+uGHXC7/NxtpnXAwD2SmfGTwOHalNyeV7eWi0NBwSF2oqBD+vk/XP6olRV194o4VbcIMiQEqOdUkOpVXlEPmxuM8s2CfqJLWlIh1iGSymxQddsKD9W5Xut6xN4LJUgFB74rsVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sBIAzX7LNuggu1SCRGXkyBJPkZ/66xtSy8G9JXUkCK4IptCL5GdVWoz7kEcR9upMRJdQezrzwwbi9BcCZJzAtZCKM+D42X4WGcfBHbN6BC4AhhEN5md//xBNTNB+YZYd47Pt0pBDFLSlXNOO2wcG+TFOj6SwXZk+J/PZQrFRNGgHnBibGY7HF3tYt/HJHe9G9lrQoWSXXzWGaUAM1H9RDk9eu4rcUD2dKnkqkA9pk8+epzWzgUvanUeLKp2zchBUgj0vgsea0LGpdjUgEndnd44OuWi7JphisyaYgrW/C2c2/j+XqG9LiLDvgP49x7YjvH0wLSv7FzeuEbe3swsu/w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 18 Nov 2024 09:27:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbN0xKZ7YiM4TBAk6CEhVFsS12wLK7wp0AgAEGmoA=
- Thread-topic: [PATCH 2/5] arm/setup: Move MMU specific extern declarations to mmu/mm.h
Hi Julien,
> On 17 Nov 2024, at 17:46, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 15/11/2024 10:50, Luca Fancellu wrote:
>> Move some extern declarations related to MMU structures and define
>> from asm/setup.h to asm/mm.h, in order to increase encapsulation and
>
> You are moving them to asm/mmu/mm.h. But I think I would prefer if they are
> moved to asm/mmu/setup.h because boot_* are not supposed to be used outside
> of boot. So it is clearer if they are still defined in a setup.h.
Sure I’ll move them to arm/mmu/setup.h
>>
>> -
>> /* Find where Xen will be residing at runtime and return a PT entry */
>> lpae_t pte_of_xenaddr(vaddr_t va);
>
> Shouldn't we move this function as well?
This one was not problematic, but I can move this one as well.
Cheers,
Luca
|
