[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] common/vmap: Fall back to simple allocator when !HAS_VMAP


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 15 Nov 2024 14:15:44 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ucc1JP7lif6TJHsQvyxxCiKlAlRkgS12bWN6XMnIODg=; b=Cdqu0IQpqyDH67AzZCuHZIvNqjtWOHZ5U3p9ZvXLrRMDvobsKg22sxkAWw1PEiiDK1jBd69ZLWtNSig7nBFV5sGU/7vIl842cwrDO3x/Pny5KSU9pKCl+Aa5u+eZhXfbOw9jrUcFGIa9EJi96dejHP6IkujSb1q1EmZucfLayPAkBiwIo6tMLQUEA6rx7oCNBouQNoPYx+FMm8mC8RyPyPARUijTMoqDrhCujglAw87emYKGD60j9r6uaxHrwxXhvcfawnQYhBp9SgiVnNNQmDUcINkudJNgNpJmcyeH4JLXv+vT9iQDEx8l4Y3rjkkhn0HvkWUBZ4T+MFc7wGTjjg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ucc1JP7lif6TJHsQvyxxCiKlAlRkgS12bWN6XMnIODg=; b=ouQHoEeD3b8XxaiXi5H8zqOB5y+YB/nkeV1JAjsN/tzkG6cQrlLvYXiSSoC71+lHsO2wO8d0DWOAVE9fMedH7o213mGYTtp9xsynFvnKHOWm+lJyW5Vx7A24BBdtS15M4fNWz8tFqx5h4BRmBaVDcCJN73HPsYL7e0llP6tACuFXYbfTP3E431XcE1RIgQ+1kNRjQTNmtb+o5ZoyuSqzMlyR/16vhtcRaIyd5GxOHoJO9tq6DoAduWBINI8OsuL0W/iaG5QdLQtqz7TFcRIkT/EmXspWpJxTaBC487IwRpB5ybJ35cYmihnWOvK/h2D3pKitQ8wJMqlucX5H8Uw/6Q==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=GBzskmZ36Mza52w6PVC+okYncGovuSgJZeS5qcUnFKwAeJ3yezDpJaQJK+dfaQyde2RYVQRcJ9pIXebjhBYyq8IpcEHXMEsqqCXVrA1qRqqD+b3O1DGTdY/678BJzulVgDpObBvFYzqlqF7pCAlmxTViAqBgpYTuV73gINfX0w5rCKTJ2R3FUrA3CjSVn2P90igO/MRpzdYhQo4UuNl3/qq9Npkm1f6rotzX5gHp/N8xW2U0qbVaLvVPuCw+cZfjOlkYeRC8BlMHtVrAHEvc23iMyJPhVWHegsRs4vyUZ0hGWLIpDFFGGXdpoFjRLYrHf/Q6hCFVzOzR9DYnrJbj8w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uPyohKlI565Hmv73uwM9EOUqVlvCbYQHQ96kyrsUvq7OP2vuKL9h7kh2m8aV5PWIAjvOkCgOqqfMz1WHLZzloHAUoC205npkrgRkoHr45CuV17qNklv9mDdwIFmGahqJsT+63rCqZrk3Ea5TM7LZG8mLNOlLKK46re1hq1I8Nz3wAu8ZiT9wCWRh5dIJppm8ZbZ6+SyJReaFP6ykdPZEo9tl1Ymlk7AKp1YXA68+M4PSFBm11E9245qa6BojKhDXkV3J6XXWXtUolOWcJrVwjkgeR5T944FMF3/9ufMWIOTlafC6M4Ok7Xv02cx8ESqf6NNzW1JGWvtNOT/13DizYA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 15 Nov 2024 14:16:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHbN0xEMVIvN3HbzEuhbXugN/BCZLK4L/YAgAAaC4CAAAkHgIAAEA8A
  • Thread-topic: [PATCH 1/5] common/vmap: Fall back to simple allocator when !HAS_VMAP


>> 
>> Sure, I’ll wrap what can’t be used in MPU case with HAS_VMAP, I would like 
>> to keep out:
>> 
>> void *vmap_contig(mfn_t mfn, unsigned int nr);
>> 
>> void vunmap(const void *va);
>> 
>> void __iomem *ioremap(paddr_t pa, size_t len);
>> 
>> static inline void iounmap(void __iomem *va)
>> 
>> static inline void vm_init(void)
>> 
>> In order to don’t put too many #ifdef, are you ok if I move the declarations 
>> in order to have these close to each other. like below:
> 
> Some re-arrangement ought to be fine, especially when the #ifdef is
> accompanied by a comment. I can't see how there can be #else though.

Yes right, clearly not tested, thanks I’ll do the changes

> 
> Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.