[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] xen/mmu: enable SMMU subsystem only in MMU
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Mon, 11 Nov 2024 11:12:29 +0000
- Cc: Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>
- Delivery-date: Mon, 11 Nov 2024 11:12:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 08/11/2024 19:59, Ayan Kumar Halder wrote:
From: Penny Zheng <Penny.Zheng@xxxxxxx>
In Xen, SMMU subsystem is supported for MMU system only. The reason being SMMU
driver uses the same page tables as MMU.
Thus, we make it dependent on CONFIG_MMU.
Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
xen/arch/arm/Kconfig | 2 +-
xen/drivers/passthrough/Kconfig | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 15b2e4a227..3699e148e9 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -16,7 +16,7 @@ config ARM
select HAS_DEVICE_TREE
select HAS_PASSTHROUGH
select HAS_UBSAN
- select IOMMU_FORCE_PT_SHARE
+ select IOMMU_FORCE_PT_SHARE if MMU
Realistically, everything under drivers/passthrough is MMU specific. So
does it actually make any sense to select HAS_PASSTHROUGH right now?
config ARCH_DEFCONFIG
string
diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
index 78edd80536..75ad403dd3 100644
--- a/xen/drivers/passthrough/Kconfig
+++ b/xen/drivers/passthrough/Kconfig
@@ -5,6 +5,7 @@ config HAS_PASSTHROUGH
if ARM
config ARM_SMMU
bool "ARM SMMUv1 and v2 driver"
+ depends on MMU
default y
help
Support for implementations of the ARM System MMU architecture
@@ -15,7 +16,7 @@ config ARM_SMMU
config ARM_SMMU_V3
bool "ARM Ltd. System MMU Version 3 (SMMUv3) Support" if EXPERT
- depends on ARM_64 && (!ACPI || BROKEN)
+ depends on ARM_64 && (!ACPI || BROKEN) && MMU
help
Support for implementations of the ARM System MMU architecture
version 3. Driver is in experimental stage and should not be used in
Cheers,
--
Julien Grall
|
