[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/44] x86/boot: introduce boot module types


  • To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 10:25:54 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728483958; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7FC7TXmamB84eXzG7JNc/+2zDsbCnDg/Whb+n+mdk7U=; b=XyrgHVtWGX5nuX8xoIo+n84Gk34az12u4HpvXtchMDJrs1YadPRhBENCiQOHWE34JobhX3A29ZPNJnLEfPPgKjplXDAUUvwlh9Z1CEFQvRH4hqLmdC6HQm6resgMHBw7gpYeRAk+aacapIJiApY/P+fCYwRqI2yj1ZSYvrHkWR8=
  • Arc-seal: i=1; a=rsa-sha256; t=1728483958; cv=none; d=zohomail.com; s=zohoarc; b=X8+Nfrh3EM7pm9fDrijmD824QcRzXL0Xl564qPODYM/AmQ2Z+NrVM5rw1KoFJrsxUo0Blp/FcSa9DgaqSQ+ggHGftH8YiQ4QCd38S2IlBaG3sUapywwYyD5+Ar97Gh1bI8LgeD3q7RzJTF6lkBpYmijLS+9xXHCgvaDY3iHIWzw=
  • Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Oct 2024 14:26:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/7/24 15:50, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
This commit introduces module types of xen, kernel, and ramdisk to allow boot module detect code to tag the purpose of a boot module. This reduces the need for hard coded order assumptions and global variables to be used by consumers
of boot modules, such as domain construction.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---

@@ -2058,6 +2063,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
             cpu_has_nx ? "" : "not ");
      initrdidx = find_first_bit(module_map, bi->nr_modules);
+    bi->mods[initrdidx].type = BOOTMOD_RAMDISK;

This is incorrect if an initrd isn't present.

Correct, will put behind guard.

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.